More detailed check for unicode gem #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can this please be merged? That'd be terrific 👍 |
4 tasks
|
@norman please be so kind and merge this 👍 |
4 tasks
|
@milch this has been merged - I see that you were watching for it to be. |
|
@parndt Thanks for pinging me! Is there a timeline for when a new version of this gem will be released? |
aried3r
added a commit
to aried3r/fastlane
that referenced
this pull request
Jun 29, 2020
Not necessary anymore with version 1.0.3 of babosa. It's not in the changelog, but you can see the fix from the PR mentioned in the comment of `babosa_fix.rb` is indeed in the 1.0.3 release. norman/babosa#42 https://my.diffend.io/gems/babosa/1.0.2/1.0.3#d2h-205265
4 tasks
joshdholtz
pushed a commit
to fastlane/fastlane
that referenced
this pull request
Jul 6, 2020
Not necessary anymore with version 1.0.3 of babosa. It's not in the changelog, but you can see the fix from the PR mentioned in the comment of `babosa_fix.rb` is indeed in the 1.0.3 release. norman/babosa#42 https://my.diffend.io/gems/babosa/1.0.2/1.0.3#d2h-205265
minuscorp
pushed a commit
to minuscorp/fastlane
that referenced
this pull request
Jul 18, 2020
Not necessary anymore with version 1.0.3 of babosa. It's not in the changelog, but you can see the fix from the PR mentioned in the comment of `babosa_fix.rb` is indeed in the 1.0.3 release. norman/babosa#42 https://my.diffend.io/gems/babosa/1.0.2/1.0.3#d2h-205265
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @norman,
I am author of a gem that adds the ability to check for the width of a unicode string: https://github.com/janlelis/unicode-display_width
It lives well together with the unicode gem and does not interfere with it in any way, however, it uses the same
Unicodenamespace.Since babosa uses the
Unicodeconstant to determine, if the unicode-display_width gem is available, but the unicode gem is not available, it will lead to aLoadError: janlelis/unicode-display_width#4The proposed fix is to check for a
VERSIONconstant, which is typically only defined for the gem of the namespace itself.