Undefined method error on edge rails

[andriytyurnikov]

undefined method `primary' for #<ActiveRecord::ConnectionAdapters::PostgreSQLColumn:0x007fd398476620>
friendly_id (5.0.3) lib/friendly_id/base.rb:225:in `each'
friendly_id (5.0.3) lib/friendly_id/base.rb:225:in `find'
friendly_id (5.0.3) lib/friendly_id/base.rb:225:in `primary_key_type'

columns.find(&:primary).type

I can not find method primary in rails docs anyways

[parndt]

Can you please give us more information like what steps you followed to get to this point?

[andriytyurnikov]

@parndt well, sure, one second, but comment about find(&:primary) would be nice anyway)))

[andriytyurnikov]

For associated model:

module MagazCore
  class Page < ActiveRecord::Base
    self.table_name = 'pages'
    extend FriendlyId
    belongs_to :shop

    friendly_id :handle, use: [:slugged, :scoped], scope: :shop

    validates :title,
      presence: true,
      uniqueness: { scope: :shop_id }

    def should_generate_new_friendly_id?
      handle_changed?
    end
  end
end

I invoke MagazCore::Shop.first.pages.friendly.find('non-existing-slug')
and get this exception

[parndt]

I'm guessing it was a method that was around on non-edge Rails? It was introduced in fda8d3c

[andriytyurnikov]

@parndt I've seen that commit, but I don't see primary as a method of ActiveRecord's column, even in rails 4.1.1

[parndt]

@andriytyurnikov strange.
@jhdavids8 can you give us any help on this one please?

[jhdavids8]

Hmm, perhaps they removed that method in edge? I don't have an edge Rails env setup at the moment, but another way to do it @andriytyurnikov is:

columns.find{ |c| c.name == primary_key}.type

If you can verify that works in your edge Rails env, perhaps we should change it to that. All we're trying to do there is find and cache the type of the column that is the primary key. Probably a few ways to do that, one of which was a 'primary' method that was true on the column that was the primary key.

[andriytyurnikov]

@jhdavids8 , I'l give it a try, but again, primary method is absent in rails 4.1.1, not only edge, see api.rubyonrails.com
I am kinda surprised that this does not fail tests

[andriytyurnikov]

@jhdavids8 , I've made monkeypatch with code, that you've offered - my tests green now, thanks!

[jhdavids8]

Great! Do you want to submit the PR with that fix?

[andriytyurnikov]

done ;)

[norman]

primary method is absent in rails 4.1.1

@andriytyurnikov I double checked this, and it's it's defined using attr_accessor :primary on 4.1 and lower. Will merge your fix for Edge Rails - thanks!