fix for UUID set on invalid object #1013
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using `:should_generate_new_friendly_id?` to enable slug update functionality, on a model which has option `friendly_id :title, use: :slugged`, and an existing `validates :title, presence: true`, the UUID is being set as the slug while the object is in an invalid state. In a rails app, this will be set as the action attribute in a `form_with` form, causing errors. Fix: Add an `errors.key?(friendly_id_config.base)` guard clause to `:unset_slug_if_invalid` callback method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug:
When using
:should_generate_new_friendly_id?to enable slug update functionality,on a model which has option
friendly_id :title, use: :slugged, and an existingvalidates :title, presence: true, the UUID is being set as the slug while theobject is in an invalid state. In a rails app, this will be set as the action
attribute in a
form_withform, causing errors.Fix:
Add an
errors.key?(friendly_id_config.base)guard clause to:unset_slug_if_invalidcallback method.