Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate output in nornir.log file #302

Closed
hoangtnk opened this issue Jan 4, 2019 · 1 comment
Closed

Duplicate output in nornir.log file #302

hoangtnk opened this issue Jan 4, 2019 · 1 comment

Comments

@hoangtnk
Copy link

hoangtnk commented Jan 4, 2019 •
edited

Hi,

It looks to me that the nornir.log file has duplicate output. Below is some content in my nornir.log file:

2019-01-03 16:30:44,584 -  nornir.core -     INFO -        run() - Running task 'netmiko_send_command' with num_workers: 20
2019-01-03 16:30:44,584 -  nornir.core -     INFO -        run() - Running task 'netmiko_send_command' with num_workers: 20
2019-01-03 16:30:44,604 -  nornir.core -    DEBUG -        run() - {'command_string': 'show interfaces status'}
2019-01-03 16:30:44,604 -  nornir.core -    DEBUG -        run() - {'command_string': 'show interfaces status'}
2019-01-03 16:30:44,637 - nornir.core.task -     INFO -      start() - test_sw_01: netmiko_send_command: running task
2019-01-03 16:30:44,637 - nornir.core.task -     INFO -      start() - test_sw_01: netmiko_send_command: running task
2019-01-03 17:16:56,505 -  nornir.core -     INFO -        run() - Running task 'netmiko_send_command' with num_workers: 20
2019-01-03 17:16:56,505 -  nornir.core -     INFO -        run() - Running task 'netmiko_send_command' with num_workers: 20
2019-01-03 17:16:56,524 -  nornir.core -    DEBUG -        run() - {'command_string': 'show interfaces status'}
2019-01-03 17:16:56,524 -  nornir.core -    DEBUG -        run() - {'command_string': 'show interfaces status'}
2019-01-03 17:16:56,597 - nornir.core.task -     INFO -      start() - test_sw_02: netmiko_send_command: running task
2019-01-03 17:16:56,597 - nornir.core.task -     INFO -      start() - test_sw_02: netmiko_send_command: running task

Is it really an issue, or did I set something wrong in my Nornir configuration?

Regards,
@dmfigol
Copy link
Collaborator

dmfigol commented Jan 20, 2019 •
edited

@hoangtnk
Can you share your nornir code as well as config.yaml ?
Thanks!
UPD: nevermind, I reproduced it successfully and fixed in #316

dmfigol added a commit to dmfigol/nornir that referenced this issue Jan 20, 2019
@dmfigol
Improve logging
cb1ba88 
Fix nornir-automation#302, nornir-automation#230

* Nornir logging is configured only when no changes have been done to Python logging
* No more duplicate logs
* Replace format and f-strings in logs to % strings according to best practices
* Improved messages for some logs
@dmfigol dmfigol mentioned this issue Jan 20, 2019
Merged
1 task
dmfigol added a commit to dmfigol/nornir that referenced this issue Feb 25, 2019
@dmfigol
Improve logging
5753e7c 
Fix nornir-automation#302, nornir-automation#230

* Nornir logging is configured only when no changes have been done to Python logging
* No more duplicate logs
* Replace format and f-strings in logs to % strings according to best practices
* Improved messages for some logs
dmfigol added a commit to dmfigol/nornir that referenced this issue Mar 5, 2019
@dmfigol
Improve logging
70a7c9b 
Fix nornir-automation#302, nornir-automation#230

* Nornir logging is configured only when no changes have been done to Python logging
* No more duplicate logs
* Replace format and f-strings in logs to % strings according to best practices
* Improved messages for some logs
dbarrosop pushed a commit that referenced this issue Mar 6, 2019
@dmfigol @dbarrosop
Improve logging (#316)
344fa4e 
* Improve logging

Fix #302, #230

* Nornir logging is configured only when no changes have been done to Python logging
* No more duplicate logs
* Replace format and f-strings in logs to % strings according to best practices
* Improved messages for some logs

* Fix build errors
* Add .ipynb_checkpoints to sphinx ignored list
* Run black and pylama on specific folders
* Pin pydantic until 0.19.0 is released
  pydantic/pydantic#254

* Add backwards compatibility and address comments

* Fix handling_connections notebook validation

* Add nbval sanitization to Makefile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dmfigol @hoangtnk