remove automatic resolver #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 531
💛 - Coveralls |
ktbyers
approved these changes
Apr 9, 2018
| assert result | ||
| for h, r in result.items(): | ||
| assert h == r.stdout.strip() | ||
| assert h == r[1].stdout.strip() |
There was a problem hiding this comment.
This seemed a bit strange...why the addition of the [1] i.e. why did it go from r.stdout.strip() to r[1].stdout.strip().
There was a problem hiding this comment.
Okay, I understand this behavior now.
There was a problem hiding this comment.
Just for reference; the reason is because instead of calling a task directly we are calling now a grouped task. Grouped tasks return a dict of results (key is host) with a list of results of which the first element is the result for the whole group.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was used very inconsistently so let's remove it. If we want it later on we can try to add it via a decorator or something like that.
Solves #107