Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add echo_data plugin #285

Merged
merged 3 commits into from
Dec 17, 2018
Merged

add echo_data plugin #285

merged 3 commits into from
Dec 17, 2018

Conversation

dbarrosop
Copy link
Contributor

This PR has two purposes:

  1. Add echo_data plugin
  2. Explore a new way of documenting and testing plugins.

For (2) the idea is to add a jupyter playbook with a working example that can be both tested and used as documentation. Basically the examples should be useful for users reserving unit tests for testing edge cases.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1056

  • 4 of 5 (80.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at ?%

Changes Missing Coverage Covered Lines Changed/Added Lines %
nornir/plugins/tasks/data/echo_data.py 2 3 66.67%
Totals Coverage Status
Change from base Build 1054: 0.0%
Covered Lines:
Relevant Lines: 0

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1056

  • 4 of 5 (80.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at ?%

Changes Missing Coverage Covered Lines Changed/Added Lines %
nornir/plugins/tasks/data/echo_data.py 2 3 66.67%
Totals Coverage Status
Change from base Build 1054: 0.0%
Covered Lines:
Relevant Lines: 0

💛 - Coveralls

@coveralls
Copy link

coveralls commented Dec 16, 2018

Pull Request Test Coverage Report for Build 1083

  • 4 of 5 (80.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at ?%

Changes Missing Coverage Covered Lines Changed/Added Lines %
nornir/plugins/tasks/data/echo_data.py 2 3 66.67%
Totals Coverage Status
Change from base Build 1061: 0.0%
Covered Lines:
Relevant Lines: 0

💛 - Coveralls

@dbarrosop dbarrosop changed the base branch from 2.0.0-beta to release December 16, 2018 15:51
@dbarrosop dbarrosop force-pushed the debug_vars branch 6 times, most recently from e526d57 to 68ac53f Compare December 17, 2018 10:07
@dbarrosop dbarrosop merged commit 976e264 into release Dec 17, 2018
@dbarrosop dbarrosop deleted the debug_vars branch August 3, 2019 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants