Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First stable release almost ready #68

Merged
merged 33 commits into from
Jan 20, 2018
Merged

First stable release almost ready #68

Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
92fed6f
allow passing dry_run to individual tasks
dbarrosop Dec 21, 2017
37e1fa5
added write task
dbarrosop Dec 21, 2017
29f4c56
redundant
dbarrosop Dec 24, 2017
2a926df
log by default to ./brigade.log
dbarrosop Dec 24, 2017
b0ca3e0
raise an error properly if we fail to connect to the device
dbarrosop Dec 24, 2017
8063186
added more devices to the lab
dbarrosop Dec 24, 2017
eadbf11
examples WIP
dbarrosop Dec 27, 2017
a230151
improvements to napalm_configure
dbarrosop Dec 27, 2017
3184632
unnecessary
dbarrosop Dec 27, 2017
027a440
improvements to logging
dbarrosop Dec 27, 2017
5e59282
better error handling
dbarrosop Dec 27, 2017
52f63f9
document new Result attributes
dbarrosop Dec 27, 2017
4972edd
allow overriding raise_on_error per task
dbarrosop Dec 29, 2017
cecc260
added napalm_validate task
dbarrosop Dec 29, 2017
30e8570
render automatically template path
dbarrosop Dec 29, 2017
0b265ce
Added helper functions to make output pretty
dbarrosop Dec 29, 2017
3e89f8c
fix napalm_validate tests
dbarrosop Dec 29, 2017
0e4027d
bugfix
dbarrosop Dec 31, 2017
ca49110
return properly dict_keys and dict_values
dbarrosop Dec 31, 2017
1e06a18
subtasks now return MultiResults which aggregate mutiple results for …
dbarrosop Jan 6, 2018
4041eec
Merge branch 'develop' of github.com:napalm-automation/brigade into r…
dbarrosop Jan 6, 2018
f830286
skip hosts if they fail and raise_on_error is False
dbarrosop Jan 6, 2018
8b8a4d6
added easy_brigade
dbarrosop Jan 6, 2018
a7096c6
added tutorials
dbarrosop Jan 6, 2018
499d11d
Merge branch 'develop' of github.com:napalm-automation/brigade into r…
dbarrosop Jan 6, 2018
308fd67
bugfix
dbarrosop Jan 15, 2018
57853e2
allow telling a task to be run on hosts that should be skipped otherwise
dbarrosop Jan 15, 2018
7824871
for consistency with tasks
dbarrosop Jan 15, 2018
b9a0d09
allow printing multiresult objects
dbarrosop Jan 15, 2018
df26d81
update docstring
dbarrosop Jan 15, 2018
707c9cc
updated examples
dbarrosop Jan 15, 2018
7e1bb53
minor fixes proposed in the comments
dbarrosop Jan 20, 2018
7b9eef3
adding missing deps
dbarrosop Jan 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions brigade/core/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ def __init__(self, inventory, dry_run, config=None, config_file=None,
logging.basicConfig(
level=logging.ERROR,
format=format,
filename="brigade.log",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, we shouldn't enable this by default. People can enable it if they want to, but shouldn't default to enabled.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recognize this changes in this commit 027a440, but still defaults to logging to brigade.log (level INFO).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#71

)
if available_connections is not None:
self.available_connections = available_connections
Expand Down