Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setuptools to dependencies #918

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Conversation

devon-mar
Copy link
Contributor

Fixes #917

setuptools 42.0.0 is the first version that supports Python 3.8, the minimum Python requirement.

@ktbyers
Copy link
Collaborator

ktbyers commented Jun 24, 2024

@devon-mar Can you rebase and update the poetry.lock file? There were some other changes recently to the lock file.

@devon-mar
Copy link
Contributor Author

@ktbyers Done

@ktbyers
Copy link
Collaborator

ktbyers commented Jun 24, 2024

setuptools is no longer guaranteed to be installed in PY3.12 and later:

https://docs.python.org/3/whatsnew/3.12.html

[gh-95299](https://github.com/python/cpython/issues/95299): Do not pre-install setuptools 
in virtual environments created with [venv](https://docs.python.org/3/library/venv.html#module-venv). 
This means that distutils, setuptools, pkg_resources, and easy_install will no longer available by 
default; to access these run pip install setuptools in the 
[activated](https://docs.python.org/3/library/venv.html#venv-explanation) virtual environment.

@ktbyers ktbyers merged commit ff2d26e into nornir-automation:main Jun 24, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

setuptools is not listed as a dependency
2 participants