Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documented current protocol #47

Merged
merged 1 commit into from Dec 18, 2020
Merged

Documented current protocol #47

merged 1 commit into from Dec 18, 2020

Conversation

ghost
Copy link

@ghost ghost commented Dec 17, 2020

This PR documents the status quo of the agent protocol and will serve as a basis for standardization.


```json
{
"listen_port": 23
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who uses 23/tcp (telnet) today? 😛

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'd be surprised. :D Anyway, it was meant as a joke. :D

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want me to change it?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either is fine 👍

@AkihiroSuda
Copy link
Collaborator

Thanks, could you sign off your commit? (git commit -a -s --amend)
https://github.com/norouter/norouter#contributing-to-norouter

Signed-off-by: Janos Pasztor <janos@pasztor.at>
@ghost
Copy link
Author

ghost commented Dec 18, 2020

Changes made and signed off. (Sorry, I thought a GPG signature would be enough.)

Copy link
Collaborator

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AkihiroSuda AkihiroSuda merged commit 21d44da into norouter:master Dec 18, 2020
@ghost ghost deleted the protocol-standardization branch December 18, 2020 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant