Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: test types with expect-type #48

Closed
norskeld opened this issue Oct 26, 2022 · 2 comments · Fixed by #75
Closed

test: test types with expect-type #48

norskeld opened this issue Oct 26, 2022 · 2 comments · Fixed by #75
Assignees
@norskeld @TheFedaikin
Labels
A-tests Area: Issues related to tests and coverage A-types Area: Issues related to types and type inference P-medium Priority: Medium R-released Semantic Release: Success

Comments

@norskeld
Copy link
Owner

Test utility and other types with expect-type, because we have tricky ones, with recursion and conditionals. It's (almost) never a bad thing to write a couple more tests.
@norskeld norskeld added the test Improvements or additions to tests label Oct 26, 2022
@norskeld norskeld self-assigned this Oct 26, 2022
@norskeld norskeld mentioned this issue Jan 14, 2023
Closed
@norskeld norskeld added A-types Area: Issues related to types and type inference A-tests Area: Issues related to tests and coverage P-medium Priority: Medium and removed test Improvements or additions to tests labels Jan 16, 2023
@norskeld
Copy link
Owner Author

Actually Vitest already provides us with utils for testing types (uses expect-type under the hood).

@TheFedaikin TheFedaikin mentioned this issue Jan 22, 2023
Merged
TheFedaikin added a commit that referenced this issue Feb 21, 2023
@TheFedaikin @norskeld
fix(types): fix inference for some parsers, add type testing (#75)
80cccf0 
Closes #48

---------

Co-authored-by: Vladislav Mamon <norskeld@gmail.com>
norskeld pushed a commit that referenced this issue Feb 21, 2023
@semantic-release-bot
chore(release): release 3.6.1 [skip ci]
bafa35e 
## [3.6.1](v3.6.0...v3.6.1) (2023-02-21)

### Bug Fixes

* **types:** fix inference for some parsers, add type testing ([#75](#75)) ([80cccf0](80cccf0)), closes [#48](#48)
@norskeld
Copy link
Owner Author

This issue has been resolved in version 3.6.1.

@norskeld norskeld added the R-released Semantic Release: Success label Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@norskeld norskeld

@TheFedaikin TheFedaikin

Labels
A-tests Area: Issues related to tests and coverage A-types Area: Issues related to types and type inference P-medium Priority: Medium R-released Semantic Release: Success
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(types): fix inference for some parsers, add type testing norskeld/sigma
2 participants
@norskeld @TheFedaikin