Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The new "Get Objects Data" node broke backward compatibility and usability #5105

Closed
rendetto opened this issue Apr 24, 2024 · 8 comments · Fixed by #5108
Closed

The new "Get Objects Data" node broke backward compatibility and usability #5105

rendetto opened this issue Apr 24, 2024 · 8 comments · Fixed by #5108

Comments

@rendetto
Copy link
Contributor

With the merge of #5022 the node "Get Objects Data" now outputs vertices and normals in Vector(( )) format.
This brakes the compatibility with other nodes and also it makes it harder to modify the data further using list nodes.

GetObjectsData_OutputFormatProblem

@satabol
Copy link
Collaborator

satabol commented Apr 25, 2024

Hi @rendetto Can you give a file for tests? I try an example of grid and do not see any vectors:

With mesh:
image

With surface:
image

Additionally:
image

@rendetto
Copy link
Contributor Author

rendetto commented Apr 25, 2024

Hello @satabol
Sorry my mistake - I wasn't changed to master after testing where the problem appeared for the first time and the "Get Objects Data" node has older UI.

Here's a screenshot from master and the problem is still present:
image

It appears that it's present when the input object is a mesh and is in edit mode. When the input mesh is in object mode the problem is not present:
image

I'm attaching the test file for convenience:
getobjectsdata_problem.zip

@satabol
Copy link
Collaborator

satabol commented Apr 25, 2024

I see. I look code and see this feature:

try:
if obj.mode == 'EDIT' and obj.type == 'MESH':
# Mesh objects do not currently return what you see
# from 3dview while in edit mode when using obj.to_mesh.
me = obj.data
bm = bmesh.from_edit_mesh(me)
# verts, edgs, pols = pydata_from_bmesh(bm)

I don't know why this feature is used but now it is work as expected.

@rendetto
Copy link
Contributor Author

rendetto commented Apr 25, 2024

Do you mean that it is supposed to output Vector when in edit mode?

@satabol
Copy link
Collaborator

satabol commented Apr 25, 2024

It is my turn to send you my sorry. I understood all problems now! ))) I need some time to think. Please wait.

@satabol
Copy link
Collaborator

satabol commented Apr 25, 2024

@rendetto Try this trick for a while: turn on numpy for vertices:

image

It will work without errors in object or edit mode now. I continue thinking...

@satabol
Copy link
Collaborator

satabol commented Apr 26, 2024

Hi @rendetto.
I fix this problem. Can you try update Sverchok and replay your scheme?
See #5108

You can turn off numpy mode of vertices now.

@rendetto
Copy link
Contributor Author

@satabol now it works as expected. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants