Fix for swiping to dismiss and cancelling by moving to the sides #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimGW
approved these changes
Mar 16, 2021
TimGW
approved these changes
Mar 16, 2021
jelleheemskerk
approved these changes
Mar 16, 2021
|
The example app doesn't build anymore, could you fix this aswell please? Beside that, I see that it's still pretty hard to drag down the image. When you drag with an angle of 160°, instead of 180° it doesn't work. |
|
Done! |
mennovogel
approved these changes
Mar 16, 2021
TimGW
approved these changes
Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug where you drag down an image (and hold it) within a viewpager and moved horizontally where it cancels and triggers the outOfBoundScrolledListener.
This fix makes the image animate back without triggering outOfBoundScrolledListener in ScrollHandler.kt