Skip to content
This repository has been archived by the owner on Jul 13, 2019. It is now read-only.

chore(cli): move catch inside self-invoking func #45

Merged
merged 1 commit into from Nov 10, 2018

Conversation

DalderupMaurice
Copy link
Member

@DalderupMaurice DalderupMaurice commented Nov 10, 2018

Description

The errors were actually never caught, this fixes the issue

Motivation and Context

better error handling

How Has This Been Tested?

throwing an error manually

Screenshots (if appropriate):

Types of changes

  • Chore (tests, refactors, and fixes)
  • New feature (adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • I have read the CONTRIBUTING document.

Closing issues

Fixes #

@jeroenptrs jeroenptrs merged commit ba24da6 into development Nov 10, 2018
@jeroenptrs jeroenptrs deleted the chore/try-catch-fix branch November 10, 2018 15:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants