Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add :provider hiccup element #25

Merged
merged 3 commits into from
Mar 4, 2019
Merged

Add :provider hiccup element #25

merged 3 commits into from
Mar 4, 2019

Conversation

dawranliou
Copy link
Contributor

Fix for #19

This PR is to:

  1. Add react/create-context thin wrapper arround react/createContext
  2. Add custom hiccup element :provider to avoid js interop
  3. Update the context example to demonstrate the usage

@lilactown
Copy link
Collaborator

This is great! I need to think of a good place to document this, but the code looks good

@lilactown
Copy link
Collaborator

I'm going to go ahead and merge this and then figure out docs before next release.

@lilactown lilactown merged commit 5633701 into nosco:master Mar 4, 2019
@dawranliou dawranliou deleted the create-context branch March 4, 2019 17:30
@dawranliou
Copy link
Contributor Author

dawranliou commented Mar 4, 2019

That sounds good to me. Thanks for merging this. Let me know if there's anything else I can do to improve this feature, like improving the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants