Fix unicode decode error in result output

[jpellerin]

Possible allternate fix for #116 (no tests yet, not ready to merge).

[coveralls]

Coverage decreased (-2.14%) when pulling daed1d3 on jpellerin:fix-unicode-decode-error-in-result into 36d026e on nose-devs:master.

[thedrow]

This pull request does not encode according to the stream's encoding. Why should it supersede #130?

[jpellerin]

I'm not saying it should, just that it's another possible approach. One
advantage it has over #130 (as currently written) is that #130 will still
crash if it is given unicode that can't be encoded according to the
stream's encoding, while version will not. Maybe combine the two
approaches, extend util.safe_decode to take an optional encoding param and
use that where #130 does?

On Wed, Dec 11, 2013 at 3:41 AM, Omer Katz notifications@github.com wrote:

This pull request does not encode according to the stream's encoding. Why
should it supersede #130 #130?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/141#issuecomment-30302992
.

[thedrow]

Yup. That sounds right. Oh btw, I do think we need a regression test for this one but I'm not sure how to write one.

p.s.
Check the mailing list.

[jpellerin]

After some further testing and work, this PR fixes the non-ascii output bug I'm seeing, but #130 doesn't. The bug has become super annoying, so I'm going to merge this now, and we can consider also merging #130 in the future, as I think it solves a different unicode/ascii issue.

[thedrow]

Great :) Thanks.