Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added error handling in setup/teardown for test suites. #200

Merged
merged 2 commits into from
Jun 11, 2014

Conversation

aloysbaillet
Copy link
Contributor

When a test suite runs setUp, tearDown and testTearDown, the calls are protected and if any error happens they are properly reported.
This fixes #140

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) when pulling 9724dc2 on aloysbaillet:fix_issue_140 into 5896c6b on nose-devs:master.

@thedrow
Copy link
Member

thedrow commented Jun 10, 2014

Great job!
Can you provide the same scenario as test_layer_teardown_fail but with such DSL so we'll make sure that there is no other problem there?

@aloysbaillet
Copy link
Contributor Author

Done! It was working fine with my change though :-)

@thedrow
Copy link
Member

thedrow commented Jun 11, 2014

I was just making sure nothing is broken. I saw that failure with Such.

thedrow added a commit that referenced this pull request Jun 11, 2014
Added error handling in setup/teardown for test suites.
@thedrow thedrow merged commit f1682a3 into nose-devs:master Jun 11, 2014
@aloysbaillet aloysbaillet deleted the fix_issue_140 branch June 30, 2014 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in teardown causes nose2 to crash
3 participants