Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for parameters with such #202

Merged
merged 1 commit into from
Jun 15, 2014

Conversation

aloysbaillet
Copy link
Contributor

The extra make_test_func is to ensure "case" is properly stored as a closure.
This fixes #139.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) when pulling 403d187 on aloysbaillet:fix_issue_139 into f1682a3 on nose-devs:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.39%) when pulling bca055f on aloysbaillet:fix_issue_139 into f1682a3 on nose-devs:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.48%) when pulling e3dd14f on aloysbaillet:fix_issue_139 into f1682a3 on nose-devs:master.

@thedrow
Copy link
Member

thedrow commented Jun 14, 2014

I need a unit test for the _test() method and a documentation change that shows how to use parameters with the Such DSL

@aloysbaillet
Copy link
Contributor Author

Hi Omer,

I'm a bit puzzled, you really want me to write a unittest for this function?
def _test(s, *args):
case(s, *args)

I'll add some documentation indeed, as using parameters with such means one has to make the first argument be "case".

@thedrow
Copy link
Member

thedrow commented Jun 15, 2014

Oh wait, I missed the last commit.
Where is the logic now?

@aloysbaillet
Copy link
Contributor Author

Haha no problem I just pushed a squashed commit including documentation.

@aloysbaillet
Copy link
Contributor Author

There's no logic needed anymore, it just works :-)

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) when pulling f7cf924 on aloysbaillet:fix_issue_139 into 27f6f83 on nose-devs:master.

thedrow added a commit that referenced this pull request Jun 15, 2014
Added support for parameters with such
@thedrow thedrow merged commit 3644c2d into nose-devs:master Jun 15, 2014
@aloysbaillet aloysbaillet deleted the fix_issue_139 branch June 30, 2014 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The parameters plugin does not work when using the Such DSL
3 participants