Fixed testSetups/testTeardowns not being run for parent layers in Such

[aloysbaillet]

It took a little while, but I think this is right...
Fixes #127

[coveralls]

Coverage decreased (-0.08%) when pulling 7ba2d3f on aloysbaillet:fix_issue_127 into d886f92 on nose-devs:master.

[coveralls]

Coverage decreased (-0.0%) when pulling 7ba2d3f on aloysbaillet:fix_issue_127 into d886f92 on nose-devs:master.

[thedrow]

What about class setUp and tearDown?

[aloysbaillet]

This test "higher_layer_setup.py" is checking the behaviour of setUp, which is only called once per layer. I assumed this was correct.

[thedrow]

Nope. Both test_setup and setup should be called once for each layer.

[aloysbaillet]

OK, but then what's the difference between test_setup and setup?

On Wed, Jul 2, 2014 at 4:28 PM, Omer Katz notifications@github.com wrote:

Nope. Both test_setup and setup should be called once for each layer.

—
Reply to this email directly or view it on GitHub
#211 (comment).

Aloys Baillet
LEGO Movie Craftman

[thedrow]

setup runs once for each layer. test_setup runs once for each test.

[aloysbaillet]

To eliminate any doubt, could you update this code to show exactly what you expect to happen?

import logging
log = logging.getLogger(__name__)

from nose2.tools import such

with such.A('foo') as it:
    it.upper_run = 0
    it.lower_run = 0

    @it.has_setup
    def upper_test_setup(case):
        log.error('foo::setUp')
        it.upper_run += 1

    with it.having('some bar'):
        @it.has_setup
        def lower_test_setup(case):
            log.error('foo some bar::setUp')
            it.lower_run += 1

        @it.should("run all setups")
        def test_run_all_setups(case):
            case.assertEquals(it.upper_run, 1)
            case.assertEquals(it.lower_run, 1)

        @it.should("run all setups just once")
        def test_run_all_setups_just_once(case):
            case.assertEquals(it.upper_run, 1)
            case.assertEquals(it.lower_run, 1)

it.createTests(globals())

[thedrow]

That's exactly what should happen.

[aloysbaillet]

Good news: that's one of the new tests in the PR:-)
On 02/07/2014 10:14 pm, "Omer Katz" notifications@github.com wrote:

That's exactly what should happen.

—
Reply to this email directly or view it on GitHub
#211 (comment).

[thedrow]

So this is mergeable? :)

[aloysbaillet]

Good question :-) I would think so, as it doesn't break anything and adds a
few more Such tests...

On Thu, Jul 3, 2014 at 9:05 AM, Omer Katz notifications@github.com wrote:

So this is mergeable? :)

—
Reply to this email directly or view it on GitHub
#211 (comment).

Aloys Baillet
LEGO Movie Craftman