Show skip reason in junitxml "message" field

docs/changelog.rst

@@ -7,6 +7,11 @@ nose2 uses semantic versioning (currently in 0.x) and the popular
 Unreleased
 ----------
 
+Changed
+~~~~~~~
+
+* skipped tests now include the user's reason in junit XML's "message" field
+
 Fixed
 ~~~~~
 

nose2/plugins/junitxml.py

@@ -161,7 +161,10 @@ def testOutcome(self, event):
             self.skipped += 1
             skipped = ET.SubElement(testcase, 'skipped')
             if msg:
-                skipped.set('message', 'test skipped')
+                skipmsg = 'test skipped'
+                if event.reason:
+                    skipmsg = 'test skipped: {}'.format(event.reason)
+                skipped.set('message', skipmsg)
                 skipped.text = msg
         elif event.outcome == result.FAIL and event.expected:
             self.skipped += 1

nose2/tests/functional/support/scenario/junitxml/skip_reason/test_junitxml_skip_reason.py

@@ -0,0 +1,8 @@
+import unittest
+
+
+class Test(unittest.TestCase):
+
+    @unittest.skip('ohai')
+    def test(self):
+        pass

nose2/tests/functional/support/scenario/junitxml/skip_reason/unittest.cfg

@@ -0,0 +1,5 @@
+[unittest]
+plugins = nose2.plugins.junitxml
+
+[junit-xml]
+always-on = True

nose2/tests/functional/test_junitxml_plugin.py

@@ -87,7 +87,6 @@ def test_report_location_should_be_resilent_to_chdir_in_tests(self):
                         "Searched for " + junit_report)
 
     def test_report_includes_properties(self):
-        scenario = ('scenario', 'junitxml', 'with_properties')
         work_dir = os.getcwd()
         with open(os.path.join(work_dir, 'properties.json'), 'w') as fh:
             fh.write('{"PROPERTY_NAME":"PROPERTY_VALUE"}')
@@ -107,6 +106,30 @@ def test_report_includes_properties(self):
         self.assertEqual(prop.get('name'), 'PROPERTY_NAME')
         self.assertEqual(prop.get('value'), 'PROPERTY_VALUE')
 
+    def test_skip_reason_in_message(self):
+        junit_report, proc = self.run_with_junitxml_loaded(
+            ("scenario", "junitxml", "skip_reason"), "--junit-xml")
+
+        self.assertTestRunOutputMatches(
+            proc,
+            stderr=r"test \(test_junitxml_skip_reason.Test\) \.* skip")
+
+        exit_status = proc.poll()
+        assert exit_status == 0
+
+        with open(junit_report, "r") as fh:
+            tree = ET.parse(fh).getroot()
+
+        num_test_cases = len(tree.findall('testcase'))
+        assert num_test_cases == 1
+
+        num_skipped = len(tree.find('testcase').findall("skipped"))
+        assert num_skipped == 1
+        skip_node = tree.find('testcase').find("skipped")
+        assert "message" in skip_node.attrib
+        skip_message = skip_node.get("message")
+        assert skip_message == "test skipped: ohai"
+
 
 class JunitXmlPluginFunctionalFailureTest(FunctionalTestCase, TestCase):
     def test_failure_to_write_report(self):

nose2/tests/unit/test_junitxml.py

@@ -175,7 +175,7 @@ def test_skip_includes_skipped(self):
         case = self.plugin.tree.find('testcase')
         skip = case.find('skipped')
         assert skip is not None
-        self.assertEqual(skip.get('message'), 'test skipped')
+        self.assertEqual(skip.get('message'), 'test skipped: skip')
         self.assertEqual(skip.text, 'skip')
 
     def test_skip_includes_skipped_no_reason(self):