Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update tests to pass on py3.11" #529

Merged
merged 1 commit into from Jul 15, 2022
Merged

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Jul 15, 2022

This reverts commit b668852 as suggested in #528 (comment).

Replaces and closes #528.

Closes #526 as no longer needed.

@sirosen
Copy link
Collaborator

sirosen commented Jul 15, 2022

Thanks for this! I just did due diligence on 3.11.0b3 vs 3.11.0b4 and can confirm that this is a behavioral change on self.assertTrue(False) (for example) in unittest, and not just some weirdness injected by the nose2 tests.

Scanning/searching through the commits between those versions, I couldn't figure out the cause. But I'm not an expert in cpython's code, so it could easily be something "obvious" that I can't recognize.

So here's what I'm going to do:

  • 🚀 merge this right now! 🚀
  • ❓ post on discuss.python.org to ask if the change is intentional or if I should expect that it could change again
  • 🧠 remember to be ready to revert-revert if this changes back in a later 3.11 version

I'll start looking through the other open PRs as soon as I get that discourse post up.

@sirosen sirosen merged commit 7831b87 into nose-devs:main Jul 15, 2022
@sirosen
Copy link
Collaborator

sirosen commented Jul 15, 2022

@hugovk hugovk deleted the fix-3.11b branch July 16, 2022 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants