Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The manifest should have a relevant error message when NAME is not installed on the target dependency #14

Closed
Symbianx opened this issue Jul 25, 2017 · 0 comments · Fixed by #15
Closed

The manifest should have a relevant error message when NAME is not installed on the target dependency #14

Symbianx opened this issue Jul 25, 2017 · 0 comments · Fixed by #15
Labels
bug
Projects
NAME Core
Milestone
1.0.1

Comments

@Symbianx
Copy link
Contributor

Currently, when NAME is not installed on the target service dependency, the manifest outputs the message "Dependency Service is not reachable", this should be changed to return a relevant message, such as "NAME is not installed."

To do this, NAME should check if the header X-NAME-Manifest-Location is present when a service dependency check fails.
@Symbianx Symbianx added the bug label Jul 25, 2017
@Symbianx Symbianx added this to the 1.0.1 milestone Jul 25, 2017
@Symbianx Symbianx added this to Backlog in NAME Core Jul 25, 2017
@Symbianx Symbianx moved this from Backlog to In Progress in NAME Core Jul 27, 2017
Symbianx pushed a commit that referenced this issue Jul 27, 2017
fixes #14 and fixes #8
9287d72
Symbianx pushed a commit that referenced this issue Jul 27, 2017
Added tests for #8 and #14
b6b45ae
@Symbianx Symbianx moved this from In Progress to In Tests in NAME Core Jul 27, 2017
@Symbianx Symbianx mentioned this issue Jul 27, 2017
Merged
Symbianx added a commit that referenced this issue Jul 28, 2017
@Symbianx
Fixes #8 and #14 (#15)
d587df2 
* fixes #14 and fixes #8

* Added tests for #8 and #14

* Fixed NAME trying to get manifest from wrong endpoint.
@Symbianx Symbianx moved this from In Tests to Done in NAME Core Nov 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
NAME Core
Done
Milestone
1.0.1
Development

Successfully merging a pull request may close this issue.

Fixes #8 and #14 nosinovacao/name-sdk
1 participant
@Symbianx