Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

error in snapshot tests #223

Closed
phillyqueso opened this issue Aug 30, 2017 · 3 comments
Closed

error in snapshot tests #223

phillyqueso opened this issue Aug 30, 2017 · 3 comments
Labels
resolved

Comments

@phillyqueso
Copy link

phillyqueso commented Aug 30, 2017 •
edited
Loading

I just installed 1.0.1, excited for the fixes. But now my tests fail... Looks like owner.element is undefined in that call stack. I checked out a local copy, added an early return check in Cleave.react.js line #355 if (!owner.element) return;, and that fixes it for me.

screen shot 2017-08-30 at 5 02 42 pm

--cheers! Let me know if you'd like PR
@nosir
Copy link
Owner

nosir commented Sep 4, 2017

Hi @phillyqueso, PR welcomed.
Thanks

@nosir
Copy link
Owner

nosir commented Jan 13, 2018

Released in https://github.com/nosir/cleave.js/releases/tag/v1.0.10

@nosir nosir closed this as completed Jan 13, 2018
@nosir nosir added the resolved label Jan 13, 2018
@nosir nosir mentioned this issue Mar 19, 2018
Closed
@leerob
Copy link

leerob commented Jan 2, 2019

If no options are supplied (in React), I'm hitting the same issue. Once I add in options, the Snapshots are generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
resolved
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nosir @phillyqueso @leerob