Prevent cascading updates in componentDidUpdate #570
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #568. Calls to
owner.onInput
withincomponentDidUpdate
eventually triggered anothercomponentDidUpdate
There may be further regressions with #527 since
componentWillReceiveProps
happens before the render cycle, butcomponentDidUpdate
happens after. But would love to see this being fixed forward since #527 is still an awesome change!Ran tests, linter, etc – lmk what else I should do.