Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] Fix double prefix display when noImmediatePrefix is set #588

Merged
merged 1 commit into from
May 19, 2020
Merged

[BUGFIX] Fix double prefix display when noImmediatePrefix is set #588

merged 1 commit into from
May 19, 2020

Conversation

PatrickDesign
Copy link
Contributor

@PatrickDesign PatrickDesign commented May 13, 2020 •
edited
Loading

Summary

  • Fix issue that would cause prefixes to display twice. Bug demo here (might have to hit refresh on the code-sandbox browser).

image

  • Add test for noImmediatePrefix option.

@PatrickDesign PatrickDesign changed the title Fix double prefix display when noImmediatePrefix is set [BUGFIX] Fix double prefix display when noImmediatePrefix is set May 13, 2020
@nosir nosir merged commit 0935353 into nosir:master May 19, 2020
@nosir
Copy link
Owner

nosir commented May 19, 2020

Thanks, but I moved the fix to Utils.js where the prefix stripped value should be fixed originally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@PatrickDesign @nosir