Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Http Adapter Fixes for Stargate #1117

Merged
merged 5 commits into from
Feb 22, 2023
Merged

Http Adapter Fixes for Stargate #1117

merged 5 commits into from
Feb 22, 2023

Conversation

jeffbanks
Copy link
Contributor

@jeffbanks jeffbanks commented Feb 17, 2023 •
edited

Includes:

  • Formatting fixes
  • Token externalized
  • Minimal cycles introduced for defaults
    • this is a new pattern being applied to built-in scenarios to avoid confusion with initial usage.
  • Standardize for nb5

@jeffbanks jeffbanks self-assigned this Feb 17, 2023
@jeffbanks jeffbanks marked this pull request as draft February 17, 2023 02:15
@jeffbanks jeffbanks marked this pull request as ready for review February 17, 2023 16:47
jshook
jshook requested changes Feb 17, 2023
View reviewed changes
Copy link
Contributor

@jshook jshook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good changes in the workloads, only minor changes requested.

@jeffbanks
Copy link
Contributor Author

@jshook this one is good for second review.

jeffreyscarpenter
jeffreyscarpenter reviewed Feb 22, 2023
View reviewed changes
Copy link
Contributor

@jeffreyscarpenter jeffreyscarpenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just had one comment regarding handling of tokens.

adapter-http/src/main/resources/activities/baselines/http-rest-keyvalue.yaml Show resolved Hide resolved
jshook
jshook approved these changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@jshook jshook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks. Merging this in for 5.17.2-preview

@jshook jshook merged commit 61ce61f into main Feb 22, 2023
@jshook jshook deleted the jeffb/cql-starter-fix branch February 22, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffreyscarpenter jeffreyscarpenter jeffreyscarpenter left review comments

@jshook jshook jshook approved these changes

Assignees

@jeffbanks jeffbanks

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jeffbanks @jshook @jeffreyscarpenter