Pc driver adapter #1280
Merged
Pc driver adapter #1280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffbanks
requested changes
May 19, 2023
adapter-pinecone/src/main/java/io/nosqlbench/adapter/pinecone/PineconeDriverAdapter.java
Outdated
Show resolved
Hide resolved
adapter-pinecone/src/main/java/io/nosqlbench/adapter/pinecone/PineconeOpMapper.java
Outdated
Show resolved
Hide resolved
...-pinecone/src/main/java/io/nosqlbench/adapter/pinecone/ops/PineconeDescribeIndexStatsOp.java
Outdated
Show resolved
Hide resolved
|
@MarkWolters one other suggestion. For the |
msmygit
reviewed
May 19, 2023
| .vscode/ | ||
|
|
||
| ### Mac OS ### | ||
| .DS_Store |
There was a problem hiding this comment.
If you prefix it with a *, it would happily take care of it on all directories
Suggested change
| .DS_Store | |
| *.DS_Store |
There was a problem hiding this comment.
Why not update the core .gitignore at the root of the project instead?
There was a problem hiding this comment.
I'm not clear if there is a change being requested here or not, please update to let me know?
There was a problem hiding this comment.
Yes, change requested. There is a .gitignore at the root of the project, and it should be adjusted rather than propogage more .gitignore files to manage.
msmygit
force-pushed
the
pc-driver-adapter
branch
from
a01337e
to
9b52ec7
Compare
jshook
reviewed
May 19, 2023
adapter-pinecone/src/main/java/io/nosqlbench/adapter/pinecone/PineconeOpMapper.java
Show resolved
Hide resolved
jshook
reviewed
May 19, 2023
...one/src/main/java/io/nosqlbench/adapter/pinecone/opdispensers/PineconeDeleteOpDispenser.java
Outdated
Show resolved
Hide resolved
jshook
reviewed
May 19, 2023
...one/src/main/java/io/nosqlbench/adapter/pinecone/opdispensers/PineconeDeleteOpDispenser.java
Show resolved
Hide resolved
jshook
reviewed
May 24, 2023
adapter-pinecone/pom.xml
Outdated
| </dependency> | ||
| </dependencies> | ||
|
|
||
| <build> |
There was a problem hiding this comment.
nit: empty build section can be removed
jshook
reviewed
May 24, 2023
...one/src/main/java/io/nosqlbench/adapter/pinecone/opdispensers/PineconeUpdateOpDispenser.java
Show resolved
Hide resolved
jshook
reviewed
May 24, 2023
adapter-pinecone/src/main/java/io/nosqlbench/adapter/pinecone/ops/PineconeFetchOp.java
Show resolved
Hide resolved
jshook
reviewed
May 24, 2023
adapter-pinecone/src/main/java/io/nosqlbench/adapter/pinecone/ops/PineconeQueryOp.java
Show resolved
Hide resolved
jshook
approved these changes
May 24, 2023
jeffbanks
approved these changes
May 24, 2023
…2.459 (#1285) Snyk has created this PR to upgrade com.amazonaws:aws-java-sdk-dynamodb from 1.12.456 to 1.12.459. See this package in Maven Repository: https://mvnrepository.com/artifact/com.amazonaws/aws-java-sdk-dynamodb/ See this project in Snyk: https://app.snyk.io/org/nosqlbench/project/db3dfb82-467b-4263-94f8-28f933540a6d?utm_source=github&utm_medium=referral&page=upgrade-pr
…1287) Snyk has created this PR to upgrade com.amazonaws:aws-java-sdk-s3 from 1.12.457 to 1.12.459. See this package in Maven Repository: https://mvnrepository.com/artifact/com.amazonaws/aws-java-sdk-s3/ See this project in Snyk: https://app.snyk.io/org/nosqlbench/project/024e32ec-7f80-485c-b7bf-f69d45f933ce?utm_source=github&utm_medium=referral&page=upgrade-pr
… 0.64.0 to 0.64.2 (#1288) Snyk has created this PR to upgrade com.vladsch.flexmark:flexmark-ext-yaml-front-matter from 0.64.0 to 0.64.2. See this package in Maven Repository: https://mvnrepository.com/artifact/com.vladsch.flexmark/flexmark-ext-yaml-front-matter/ See this project in Snyk: https://app.snyk.io/org/nosqlbench/project/024e32ec-7f80-485c-b7bf-f69d45f933ce?utm_source=github&utm_medium=referral&page=upgrade-pr
Snyk has created this PR to upgrade com.amazonaws:aws-java-sdk-s3 from 1.12.459 to 1.12.460. See this package in Maven Repository: https://mvnrepository.com/artifact/com.amazonaws/aws-java-sdk-s3/ See this project in Snyk: https://app.snyk.io/org/nosqlbench/project/024e32ec-7f80-485c-b7bf-f69d45f933ce?utm_source=github&utm_medium=referral&page=upgrade-pr
- introduce a new WriteOp to write directly to Venice - support AVRO keys for reads and for writes - remove useless metrics
….6.3 (#1294) Snyk has created this PR to upgrade org.apache.tinkerpop:tinkergraph-gremlin from 3.6.2 to 3.6.3. See this package in Maven Repository: https://mvnrepository.com/artifact/org.apache.tinkerpop/tinkergraph-gremlin/ See this project in Snyk: https://app.snyk.io/org/nosqlbench/project/73081f87-c1b7-4c91-b407-1cb299565642?utm_source=github&utm_medium=referral&page=upgrade-pr Co-authored-by: snyk-bot <snyk-bot@snyk.io>
…4.2 to 0.64.4 (#1293) Snyk has created this PR to upgrade com.vladsch.flexmark:flexmark-html2md-converter from 0.64.2 to 0.64.4. See this package in Maven Repository: https://mvnrepository.com/artifact/com.vladsch.flexmark/flexmark-html2md-converter/ See this project in Snyk: https://app.snyk.io/org/nosqlbench/project/453e17d8-dd56-4df1-a6f6-f11fbe9f6022?utm_source=github&utm_medium=referral&page=upgrade-pr Co-authored-by: snyk-bot <snyk-bot@snyk.io>
… 0.64.0 to 0.64.4 (#1292) Snyk has created this PR to upgrade com.vladsch.flexmark:flexmark-ext-yaml-front-matter from 0.64.0 to 0.64.4. See this package in Maven Repository: https://mvnrepository.com/artifact/com.vladsch.flexmark/flexmark-ext-yaml-front-matter/ See this project in Snyk: https://app.snyk.io/org/nosqlbench/project/453e17d8-dd56-4df1-a6f6-f11fbe9f6022?utm_source=github&utm_medium=referral&page=upgrade-pr Co-authored-by: snyk-bot <snyk-bot@snyk.io>
…io script from the activity context
Snyk has created this PR to upgrade com.amazonaws:aws-java-sdk-s3 from 1.12.460 to 1.12.462. See this package in Maven Repository: https://mvnrepository.com/artifact/com.amazonaws/aws-java-sdk-s3/ See this project in Snyk: https://app.snyk.io/org/nosqlbench/project/024e32ec-7f80-485c-b7bf-f69d45f933ce?utm_source=github&utm_medium=referral&page=upgrade-pr
Snyk has created this PR to upgrade com.github.oshi:oshi-core-java11 from 6.4.1 to 6.4.2. See this package in Maven Repository: https://mvnrepository.com/artifact/com.github.oshi/oshi-core-java11/ See this project in Snyk: https://app.snyk.io/org/nosqlbench/project/024e32ec-7f80-485c-b7bf-f69d45f933ce?utm_source=github&utm_medium=referral&page=upgrade-pr
…4.2 to 0.64.4 Snyk has created this PR to upgrade com.vladsch.flexmark:flexmark-html2md-converter from 0.64.2 to 0.64.4. See this package in Maven Repository: https://mvnrepository.com/artifact/com.vladsch.flexmark/flexmark-html2md-converter/ See this project in Snyk: https://app.snyk.io/org/nosqlbench/project/024e32ec-7f80-485c-b7bf-f69d45f933ce?utm_source=github&utm_medium=referral&page=upgrade-pr
… 0.64.2 to 0.64.4 Snyk has created this PR to upgrade com.vladsch.flexmark:flexmark-ext-yaml-front-matter from 0.64.2 to 0.64.4. See this package in Maven Repository: https://mvnrepository.com/artifact/com.vladsch.flexmark/flexmark-ext-yaml-front-matter/ See this project in Snyk: https://app.snyk.io/org/nosqlbench/project/024e32ec-7f80-485c-b7bf-f69d45f933ce?utm_source=github&utm_medium=referral&page=upgrade-pr
…2.462 Snyk has created this PR to upgrade com.amazonaws:aws-java-sdk-dynamodb from 1.12.459 to 1.12.462. See this package in Maven Repository: https://mvnrepository.com/artifact/com.amazonaws/aws-java-sdk-dynamodb/ See this project in Snyk: https://app.snyk.io/org/nosqlbench/project/db3dfb82-467b-4263-94f8-28f933540a6d?utm_source=github&utm_medium=referral&page=upgrade-pr
|
Fixes #1252 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First cut of the pinecone driver adapter implementation.
Wraps the driver available at https://github.com/pinecone-io/pinecone-java-client/tree/main
Ops and Dispensers implemented for all types specified in https://github.com/pinecone-io/pinecone-java-client/blob/main/src/main/proto/vector_service.proto