#1537: Sanity checking on client side load should be included into core metrics and async warnings #1601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
None of the parsers or the checker are currently living in the correct place. Please suggest a better place for me to move those classes to. |
jshook
reviewed
Oct 5, 2023
| * limitations under the License. | ||
| */ | ||
|
|
||
| package io.nosqlbench.engine.api.activityimpl.uniform; |
There was a problem hiding this comment.
We should probably have all of these classes under some "clientload" package in the engine-core module.
MarkWolters
reviewed
Oct 5, 2023
| private static final Logger logger = LogManager.getLogger(ClientSystemMetricChecker.class); | ||
| private final int pollIntervalSeconds; | ||
| private final ScheduledExecutorService scheduler; | ||
| private final Map<String,Gauge<Double>> nameToNumerator; |
There was a problem hiding this comment.
It seems to me that, as these values are all accessed together, it might be more efficient to create a nested class like
private class ClientMetrics {
Gauge numerator,
Gauge denominator,
...
} ,
Store that by name in a Map and store/retrieve everything with a single call
| int sectorSizeBytes = 512; | ||
| String line; | ||
| while ((line = reader.readLine()) != null) { | ||
| String[] parts = line.trim().split("\\s+"); |
There was a problem hiding this comment.
I would recommend putting a try/catch inside the while loop as well, so that if a single line in the file is corrupted and e.g. parseDouble runs into something weird and throws and exception, the whole file reading process doesn't have to bail
| metricsMap.put("loadAvg15min", loadAvgFifteenMinute); | ||
|
|
||
| } catch (FileNotFoundException e) { | ||
| return; |
There was a problem hiding this comment.
This then results in the null value bubbling up to the original caller silently. If that's what's intended, that's fine. Just mentioning it.
jshook
reviewed
Oct 6, 2023
There was a problem hiding this comment.
Some notes on approach:
It would be best to reduce the usage of Map here where possible. Many small maps will have an out-sized impact on memory usage. In some cases here, you could easily use arrays or Lists, since the consumer side of this data simply wants to iterate over the established data sources.
I would also advocate for bundling the basic (find, extract, check) style patterns into a type which can be applied to each, rather than keep things in tabular form. Happy to go into more details if you like.
ShaunakDas88
force-pushed
the
client_metrics
branch
4 times, most recently
from
ec9e848
to
19769fc
Compare
ShaunakDas88
force-pushed
the
client_metrics
branch
from
19769fc
to
cd1ab9c
Compare
|
Thanks for the feedback, this is now ready for another round of reviews. A few changes, so the highlights:
Local Testing For the client metric checking, I run cpuburn locally to artificially max out CPU usage, and it triggers the threshold check for CPU percentage spent in user space, then no more after CPU burn is killed (the sleep 30s): |
MarkWolters
reviewed
Oct 11, 2023
jshook
approved these changes
Oct 12, 2023
|
Thanks for the reviews, guys. @MarkWolters I agree that it makes sense to move the registration to NBSession, but that class currently is not available in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #1537