Update the built-in cql-vector workload file #1602

yabinmeng · 2023-10-05T01:34:51Z

Also fix 2 minor issues:

if the cycles parameter is not explicitly specified, it should by default set to the stride number. the current code failed to do so
In ActivityExecutor, the method of unregisterMetrics() may be called when the method registerMetrics() wasn't called earlier. This will cause NPE.

…ctly setting the cycle count to the stride count if the cycle count is not specified explicitly.

…ashed. This makes sure the generated embedding values are not the same.

…sterMetrics()` fails to execute somehow (e.g. CLI input parameter problem such as cycle number < stride number)

jshook

Thanks!

Update the built-in cql-vector workload and fix an issue of not corre…

b7dd97c

…ctly setting the cycle count to the stride count if the cycle count is not specified explicitly.

yabinmeng requested a review from jshook October 5, 2023 01:35

yabinmeng added 3 commits October 4, 2023 21:22

Change vector_value binding generation from ListSized to ListSizedH…

2213676

…ashed. This makes sure the generated embedding values are not the same.

Fix a possible NPE situation caused by unregisterMetrics() if `regi…

47c87c6

…sterMetrics()` fails to execute somehow (e.g. CLI input parameter problem such as cycle number < stride number)

Merge branch 'nosqlbench:main' into rm-docker-metrics

e2d8107

jshook approved these changes Oct 5, 2023

View reviewed changes

jshook merged commit aa88c22 into nosqlbench:main Oct 5, 2023
6 checks passed

yabinmeng deleted the rm-docker-metrics branch October 6, 2023 14:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update the built-in cql-vector workload file #1602

Update the built-in cql-vector workload file #1602

yabinmeng commented Oct 5, 2023 •

edited

jshook left a comment

Update the built-in cql-vector workload file #1602

Update the built-in cql-vector workload file #1602

Conversation

yabinmeng commented Oct 5, 2023 • edited

jshook left a comment

Choose a reason for hiding this comment

yabinmeng commented Oct 5, 2023 •

edited