Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

basic sanity check on tags, no newlines or spaces #1619

Merged
merged 1 commit into from
Oct 12, 2023
Merged

basic sanity check on tags, no newlines or spaces #1619

merged 1 commit into from
Oct 12, 2023

Conversation

jshook
Copy link
Contributor

@jshook jshook commented Oct 12, 2023

This makes yaml editing a bit safer for some cases.

@jshook jshook linked an issue Oct 12, 2023 that may be closed by this pull request
tag names or values which contain newlines or special characters should be rejected #1617
Closed
MarkWolters
MarkWolters approved these changes Oct 12, 2023
View reviewed changes
Copy link
Collaborator

@MarkWolters MarkWolters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

@MarkWolters MarkWolters merged commit 78ff0a3 into main Oct 12, 2023
8 checks passed
@jshook jshook deleted the jshook/tagsafety branch October 18, 2023 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkWolters MarkWolters MarkWolters approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tag names or values which contain newlines or special characters should be rejected
2 participants
@jshook @MarkWolters