Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Major NB JDBC driver updates in order to support pg-vector #1624

Merged
merged 10 commits into from
Oct 18, 2023
Merged

Major NB JDBC driver updates in order to support pg-vector #1624

merged 10 commits into from
Oct 18, 2023

Conversation

yabinmeng
Copy link
Contributor

  • Add PreparedStatement support
  • Add batch update for DML write statements
  • Add client-side connection pooling (needed for thread safety)
  • Address issues caused by the fact that JDBC connection and statement are not thread-safe
  • Fix the issue of no Vector value returned when running Vector queries
  • Add the template yaml file for NB pg vector with relevancy score verificationn

@yabinmeng
Major NB JDBC driver updates in order to support pg-vector
179a51c 
- Add PreparedStatement support
- Add batch update for DML write statements
- Add client-side connection pooling (needed for thread safety)
- Address issues caused by the fact that JDBC connection and statement are not thread-safe
- Fix the issue of no Vector value returned when running Vector queries
- Add the template yaml file for NB pg vector with relevancy score verificationn
@yabinmeng yabinmeng requested a review from jshook October 16, 2023 04:55
@yabinmeng yabinmeng marked this pull request as draft October 16, 2023 16:12
jshook
jshook approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@jshook jshook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yabinmeng yabinmeng marked this pull request as ready for review October 16, 2023 19:49
msmygit
msmygit reviewed Oct 16, 2023
View reviewed changes
pom.xml Outdated Show resolved Hide resolved
jshook
jshook reviewed Oct 16, 2023
View reviewed changes
pom.xml Outdated Show resolved Hide resolved
jshook
jshook approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@jshook jshook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some design/structural concerns which we'll need to address before calling this adapter finished. For now, let's roll with it and get some UAT time on it.

@yabinmeng
Copy link
Contributor Author

Confirming

@yabinmeng
Copy link
Contributor Author

Merge

@yabinmeng yabinmeng merged commit 45b5e52 into nosqlbench:main Oct 18, 2023
6 checks passed
@msmygit
Copy link
Contributor

msmygit commented Oct 18, 2023

We may have to modify/update the other workload yamls under baselines2 directory to confirm to the new layout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jshook jshook jshook approved these changes

@msmygit msmygit msmygit approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yabinmeng @msmygit @jshook