Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qdrant driver - updates #1947

Merged
merged 5 commits into from
May 14, 2024
Merged

Qdrant driver - updates #1947

merged 5 commits into from
May 14, 2024

Conversation

msmygit
Copy link
Contributor

@msmygit msmygit commented May 13, 2024

  • Implemented full-fledged filtering logic
  • Removed maven properties versioning based on PR review feedback
  • Updates to create payload index operation

@msmygit msmygit enabled auto-merge May 13, 2024 21:36
@msmygit msmygit force-pushed the ms/qdrant branch 2 times, most recently from fdbaf67 to 57d854f Compare May 14, 2024 00:36
@msmygit msmygit marked this pull request as draft May 14, 2024 02:56
auto-merge was automatically disabled May 14, 2024 02:56

Pull request was converted to draft

@msmygit msmygit marked this pull request as ready for review May 14, 2024 03:25
Copy link
Collaborator

@MarkWolters MarkWolters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Filter logic must have been fun to write!

@@ -41,8 +41,6 @@

<PROG>nb5</PROG>
<maven.plugin.validation>VERBOSE</maven.plugin.validation>

<jacoco.version>0.8.12</jacoco.version>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This stemmed from #1942 (comment)

@msmygit
Copy link
Contributor Author

msmygit commented May 14, 2024

looks good. Filter logic must have been fun to write!

it certainly was! 😄

@msmygit msmygit merged commit e9b4087 into main May 14, 2024
5 checks passed
@msmygit msmygit deleted the ms/qdrant branch May 14, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants