-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JDBC Driver implementation - Initial Draft #990
Conversation
Snyk has created this PR to upgrade org.snakeyaml:snakeyaml-engine from 2.5 to 2.6. See this package in Maven Repository: https://mvnrepository.com/artifact/org.snakeyaml/snakeyaml-engine/ See this project in Snyk: https://app.snyk.io/org/nosqlbench/project/024e32ec-7f80-485c-b7bf-f69d45f933ce?utm_source=github&utm_medium=referral&page=upgrade-pr
nb5/pom.xml version squash
adapter-jdbc/src/main/java/io/nosqlbench/adapter/jdbc/JDBCOpType.java
Outdated
Show resolved
Hide resolved
adapter-jdbc/src/main/java/io/nosqlbench/adapter/jdbc/optypes/JDBCExecuteOp.java
Outdated
Show resolved
Hide resolved
adapter-jdbc/src/main/java/io/nosqlbench/adapter/jdbc/optypes/JDBCExecuteOp.java
Outdated
Show resolved
Hide resolved
adapter-jdbc/src/main/java/io/nosqlbench/adapter/jdbc/optypes/JDBCExecuteOp.java
Outdated
Show resolved
Hide resolved
adapter-jdbc/src/main/java/io/nosqlbench/adapter/jdbc/JDBCSpace.java
Outdated
Show resolved
Hide resolved
adapter-jdbc/src/main/java/io/nosqlbench/adapter/jdbc/JDBCSpace.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, a solid addition. There are some formatting, optimization, requests before it is ready for merge.
@all-contributors please add @jshook for mentoring |
I've put up a pull request to add @jshook! 🎉 |
@all-contributors add @msmygit for code bug doc ideas question research review tools userTesting talk tutorial |
@all-contributors add @MikeYaacoubStax as review tools |
I've put up a pull request to add @MikeYaacoubStax! 🎉 |
adapter-jdbc/src/main/java/io/nosqlbench/adapter/jdbc/JDBCOpMapper.java
Outdated
Show resolved
Hide resolved
adapter-jdbc/src/main/java/io/nosqlbench/adapter/jdbc/JDBCSpace.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks for making all the requested changes!
JDBC Driver implementation - Initial Draft with working prototype.