Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDBC Driver implementation - Initial Draft #990

Merged
merged 28 commits into from
Feb 8, 2023
Merged

JDBC Driver implementation - Initial Draft #990

merged 28 commits into from
Feb 8, 2023

Conversation

msmygit
Copy link
Contributor

@msmygit msmygit commented Feb 4, 2023

JDBC Driver implementation - Initial Draft with working prototype.

@msmygit msmygit self-assigned this Feb 4, 2023
pom.xml Show resolved Hide resolved
Copy link
Contributor

@jshook jshook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, a solid addition. There are some formatting, optimization, requests before it is ready for merge.

@msmygit
Copy link
Contributor Author

msmygit commented Feb 7, 2023

@all-contributors please add @jshook for mentoring

@allcontributors
Copy link
Contributor

@msmygit

I've put up a pull request to add @jshook! 🎉

@msmygit
Copy link
Contributor Author

msmygit commented Feb 7, 2023

@all-contributors add @msmygit for code bug doc ideas question research review tools userTesting talk tutorial

@allcontributors
Copy link
Contributor

@msmygit

@msmygit already contributed before to code, bug, doc, ideas, question, research, review, tool, userTesting, talk, tutorial

@msmygit
Copy link
Contributor Author

msmygit commented Feb 7, 2023

@all-contributors add @MikeYaacoubStax as review tools

@allcontributors
Copy link
Contributor

@msmygit

I've put up a pull request to add @MikeYaacoubStax! 🎉

@msmygit msmygit requested a review from jshook February 8, 2023 02:49
@msmygit msmygit added the enhancement New feature or request label Feb 8, 2023
@msmygit msmygit marked this pull request as ready for review February 8, 2023 02:50
@msmygit msmygit requested a review from jshook February 8, 2023 15:46
Copy link
Contributor

@jshook jshook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for making all the requested changes!

@msmygit msmygit merged commit bffa9d6 into main Feb 8, 2023
@msmygit msmygit deleted the adapter-jdbc branch February 8, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

None yet

3 participants