Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build CSS with CI #13

Closed
BcRikko opened this issue Nov 28, 2018 · 10 comments
Closed

Build CSS with CI #13

BcRikko opened this issue Nov 28, 2018 · 10 comments
Assignees
@BcRikko
Labels
enhancement New feature or request released

Comments

@BcRikko
Copy link
Member

BcRikko commented Nov 28, 2018

cssファイルがコンフリクトしてしまうので、masterにマージしたときにCIでビルドしたい
@BcRikko BcRikko self-assigned this Nov 28, 2018
@BcRikko BcRikko changed the title CSSファイルをCIでビルドしたい Build CSS with CI Nov 30, 2018
@BcRikko
Copy link
Member Author

BcRikko commented Nov 30, 2018

Travis CI

Always free for open source projects
https://travis-ci.com/plans

Circle CI

1,000 build minutes per month
https://circleci.com/pricing/

@trezy
Copy link
Member

trezy commented Nov 30, 2018

@BcRikko Have you already started on this? If not, I'd love to help out. I'll fork this afternoon and get it set up on CircleCI if that works for you.

I also have a few suggestions that would make it easier to manage the community that you're very swiftly building.

  1. Create a develop branch
    Many large repositories have a develop branch for people to merge their pull requests into. This allows the original repo to accept a PR without merging it directly into master, therefore allowing CI to run without affecting production builds.
  2. Set up Commitizen
    With a popular repo like this, there are a lot of different contributors, each with their own style of writing. This is great because it means more features get created faster and more bugs get fixed sooner, but it also makes it really hard to review commits just based on their messages. Commitizen helps out by forcing contributors to use a standard commit message format.
  3. Set up semantic-release
    semantic-release automates the entire process of version bumping, changelog generation, and publishing to package managers (like npm). It's a great thing to set up with CI because, as they say in their README:

    ...releases are guaranteed to be unromantic and unsentimental.

Again, I don't want to step on your feet so let me know if you want me to chip in on this one. 😉

@BcRikko
Copy link
Member Author

BcRikko commented Dec 1, 2018

I have not started this issue yet.
I'm the first time that I became the owner of a product that many people pay attention. 😨

so, please help me 🙏
and could you give me some advice please? 🙏

@BcRikko BcRikko mentioned this issue Dec 1, 2018
Closed
@trezy
Copy link
Member

trezy commented Dec 1, 2018

@BcRikko of course! I did fork and start working on setting up CI this afternoon. You can check out what I’ve got so far on my fork: https://github.com/trezy/NES.css/blob/master/.circleci/config.yml

@BcRikko
Copy link
Member Author

BcRikko commented Dec 1, 2018

oh, Thanks 🎉🎉🎉

@BcRikko BcRikko mentioned this issue Dec 1, 2018
Merged
@montezume
Copy link
Contributor

How about adding the built css to gitignore once this is done? 🙏

@BcRikko
Copy link
Member Author

BcRikko commented Dec 1, 2018 •
edited

I agree 👍
It's too much hassle to resolve conflicting files... 😢

so, I'd like to build CSS(dist files) with CI. 🛠

@montezume
Copy link
Contributor

Yes, let CI build css.

Image of bender

@trezy
Copy link
Member

trezy commented Dec 1, 2018

Yup, I'm working on getting semantic-release set up right now. Once that's done I'll make the PR, then we can make separate issues to cover adding release targets (cdnjs, npm, etc). Once that's done, it'll make sense to remove the compiled CSS files from the repo. 😁

BcRikko pushed a commit that referenced this issue Dec 5, 2018
@trezy @BcRikko
ci: Add semantic-release
879a805 
Add `semantic-release` to the repo and the build pipeline. This will handle automatically publishing
to npm based on commit messages.

#13
BcRikko pushed a commit that referenced this issue Dec 5, 2018
@trezy @BcRikko
ci: Switch to the CircleCI Node container
96362f8 
The Roll For Guild Node container doesn't include `git`, which is required by semantic-release.

#13
BcRikko pushed a commit that referenced this issue Dec 5, 2018
@trezy @BcRikko
ci: add commitlint
3ec9ab1 
Add `commitlint` to enforce proper formatting for all commit messages

#13
trezy added a commit that referenced this issue Dec 6, 2018
@trezy
ci: allow build to run on all branches
f4eb84a 
Since we don't have any tests yet, we want to make sure the build runs successfully on all branches.
That way we can at least verify that the build works correctly.

closes #13
@abdallahalsamman abdallahalsamman mentioned this issue Dec 7, 2018
Closed
@trezy trezy added enhancement New feature or request and removed improvement labels Dec 9, 2018
trezy added a commit that referenced this issue Dec 10, 2018
@trezy
build(commitlint): Remove semantic-commitlint
e5ab238 
This removes `semantic-commitlint` from both the local build pipeline and the CI build pipeline. The
original value of `semantic-commitlint` was that it would handle linting only the relevant commits,
i.e. the commit range under review for a PR. However, the library doesn't seem to respect our
altered `commitlint` rules, so we'll be switching to an alternate strategy to handle linting of
specific ranges.

#13
trezy added a commit that referenced this issue Dec 10, 2018
@trezy
build(commitlint): Add circleci-commitlint-step
a459915 
I've added `circleci-commitlint-step` because it *should* handle linting of the appropriate
commitlint ranges via a specialized Docker container for CircleCI with a commit range.

#13
@trezy trezy closed this as completed Dec 10, 2018
@BcRikko
Copy link
Member Author

BcRikko commented Dec 18, 2018

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BcRikko BcRikko

Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@trezy @montezume @BcRikko