Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ballons dark mode #345

Closed
guastallaigor opened this issue Jun 4, 2019 · 5 comments
Closed

Add Ballons dark mode #345

guastallaigor opened this issue Jun 4, 2019 · 5 comments
Labels
enhancement New feature or request

Comments

@guastallaigor
Copy link
Member

Is your feature request related to a problem? Please describe.
I propose to create a Balloons is-dark class, similar to the other components, because we are missing just a few components that doesn't have the is-dark class.

Describe the solution you'd like
Something similar to the containers, tables or dialogs.
After creating, add it to the docs as well.
I don't have a draft for this yet.

Describe alternatives you've considered
Don't add it at all.

Additional context
Maybe add this after #331.

@guastallaigor guastallaigor added the enhancement New feature or request label Jun 4, 2019
@youngkaneda
Copy link
Contributor

@guastallaigor i could do this today if not exist an already PR for this.

@guastallaigor
Copy link
Member Author

@youngkaneda Great, thank you 😄. I don't think there's anyone working in this at the moment, so no PRs 👍

@hovi
Copy link

hovi commented Jul 29, 2019

Hey guys, any progress on this?

@guastallaigor
Copy link
Member Author

I'm not sure. I haven't tried anything myself.

HiKaylum added a commit to HiKaylum/NES.css that referenced this issue Oct 11, 2019
Implementation so balloons can now have `is-dark`

re nostalgic-css#345
HiKaylum added a commit to HiKaylum/NES.css that referenced this issue Oct 11, 2019
Implementation so balloons can now have `is-dark`

re nostalgic-css#345
HiKaylum added a commit to HiKaylum/NES.css that referenced this issue Oct 11, 2019
Implementation so balloons can now have `is-dark`

re nostalgic-css#345
@HiKaylum
Copy link
Contributor

I have created a PR for this.

Also sorry for the ref comments 😅ran into branching / commit issue due to being a spud!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants