Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot install nes.css with latest node versions #414

Closed
doliG opened this issue Apr 8, 2020 · 5 comments
Closed

Cannot install nes.css with latest node versions #414

doliG opened this issue Apr 8, 2020 · 5 comments
Labels
devops CI, build, and deployment issues

Comments

@doliG
Copy link

doliG commented Apr 8, 2020

Describe the bug

❯ yarn add nes.css@latest
yarn add v1.22.4
[1/4] πŸ”  Resolving packages...
[2/4] 🚚  Fetching packages...
error nes.css@2.3.0: The engine "node" is incompatible with this module. Expected version "10.x". Got "13.11.0"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/add for documentation about this command.

To Reproduce

  1. Install node > 13
  2. Try to install nes.css via yarn

Expected behavior
The installation works.

Environment:

  • OS: MacOS Mojave
  • Build environment (i.e. NodeJS): Node 13

Suggestion(s) for fixing this issue
Well, I manage to install nes.css with downgrading my node version to 10.19.0. However, this is not a fix, but a workaround.

Looks like the solution is here: #392 (comment)

I can create a PR is you want.

@BcRikko BcRikko added duplicate This issue or pull request already exists devops CI, build, and deployment issues and removed duplicate This issue or pull request already exists labels Apr 8, 2020
@BcRikko
Copy link
Member

BcRikko commented Apr 8, 2020

Currently, NES.css is using node-sass@4.12.0. The reason you can't install NES.css is in node-sass. (#392 (comment))

I can create a PR is you want.

Yeah πŸ‘
I'd appreciate it if you could send a PR to this repository.
Probably just upgrading the version of node-sass to 4.13.x. πŸ€”

@candywater
Copy link

Small problem but a little different

Cannot install nes.css via yarn, node version is 12.13.0
but can install nes.css via npm, node version is 12.13.0

here is yarn error message

[1/4] Resolving packages...
[2/4] Fetching packages...
error nes.css@2.3.0: The engine "node" is incompatible with this module. Expected version "10.x". Got "12.13.0"
error Found incompatible module.

here is npm warning message

npm WARN saveError ENOENT: no such file or directory, open '/mnt/e/work_space/learning/nes/package.json'
npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN notsup Unsupported engine for nes.css@2.3.0: wanted: {"node":"10.x"} (current: {"node":"12.13.0","npm":"6.12.0"})
npm WARN notsup Not compatible with your version of node/npm: nes.css@2.3.0
npm WARN enoent ENOENT: no such file or directory, open '/mnt/e/work_space/learning/nes/package.json'
npm WARN nes No description
npm WARN nes No repository field.
npm WARN nes No README data
npm WARN nes No license field.

+ nes.css@2.3.0
added 1 package from 1 contributor and audited 1 package in 6.594s
found 0 vulnerabilities

@doliG
Copy link
Author

doliG commented May 6, 2020

@candywater Thanks for the informations. This is, indeed, weird.

Maybe yarn and npm have different strategies to handle unsupported engine, where yarn raise an error and stop, npm just show a warning and try to do it anyway πŸ€”

@ghost
Copy link

ghost commented May 9, 2020

same problem

@virtuoushub
Copy link

virtuoushub commented May 9, 2020

@doliG / @candywater yes yarn is a bit more strict in that it will bomb w/ unsupported engines by default.

To get around this you can use: yarn install --ignore-engines.

virtuoushub pushed a commit to virtuoushub/NES.css that referenced this issue May 10, 2020
Closes nostalgic-css#414
supersedes nostalgic-css#415 (upgraded node-sass allows for Node 14)
virtuoushub pushed a commit to virtuoushub/NES.css that referenced this issue May 10, 2020
Closes nostalgic-css#414
Closes nostalgic-css#415 (that PR willed be superseded b/c this one upgrades node-sass to allow for Node 14)
virtuoushub pushed a commit to virtuoushub/NES.css that referenced this issue May 10, 2020
Closes nostalgic-css#414
Closes nostalgic-css#415 (that PR willed be superseded b/c this one upgrades node-sass to allow for Node 14)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops CI, build, and deployment issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants