Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Chinese simplified translation for README. #186

Closed
wants to merge 1 commit into from
Closed

Add Chinese simplified translation for README. #186

wants to merge 1 commit into from

Conversation

kenshinji
Copy link
Contributor

I created Chinese translation for README. :)

@kenshinji kenshinji mentioned this pull request Dec 14, 2018
Closed
@guastallaigor guastallaigor added enhancement New feature or request documentation Adding, removing, or updating documentation labels Dec 14, 2018
@guastallaigor guastallaigor requested a review from a team December 14, 2018 18:20
@trezy
Copy link
Member

trezy commented Dec 14, 2018

Hey @kenshinji, thanks so much for the translation! However, we just updated all of our docs and made sure we had several translations for them. 😬

Would you mind pulling down the update-docs branch and working off of that? We need an updated README-zh-CN.md, CONTRIBUTING-zh-CN.md, and CODE_OF_CONDUCT-zh-CN.md. If you could also add links all of the other docs, that would be amazing. ❤️

@kenshinji
Copy link
Contributor Author

Ok, will do that later ;)

@trezy
Copy link
Member

trezy commented Dec 16, 2018

Just a heads up, @kenshinji, we’ve just merged the new versions of all of our documents. Make sure to pull down the develop branch and work off of that. 😉

@trezy trezy added waiting - contributor Waiting for the contributor to address some situations translations Adding or correcting translations and removed enhancement New feature or request labels Dec 17, 2018
@trezy
Copy link
Member

trezy commented Dec 20, 2018

Hey @kenshinji, were you able to update the translated docs?

@kenshinji
Copy link
Contributor Author

@trezy yeah, sure, crazy busy these days, I'll update it before the end of this week, good?

@kenshinji
Copy link
Contributor Author

@trezy I created a new PR here #225, pls help me to review and merge, thanks.

@guastallaigor guastallaigor added duplicate This issue or pull request already exists and removed waiting - contributor Waiting for the contributor to address some situations labels Dec 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kenshinji kenshinji

Labels
documentation Adding, removing, or updating documentation duplicate This issue or pull request already exists translations Adding or correcting translations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kenshinji @trezy @guastallaigor