Adds focus style change for buttons #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR allows users navigating by <kbd>Tab</kbd> to visually have an idea of where they are in the DOM, by giving buttons the same visual style as if they were hovered by a mouse. This is important as people who navigate by use of non-mouse input devices (keyboards) would have no visual cue of where keyboard focus presently was, due to setting `:focus { outline: 0 }`
|
Looks like #24 duplicates and expands on this PR. I will close this so as to not have conflicting work. |
|
Thanks for closing PR. 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows users navigating by Tab to visually have an idea of where they are in the DOM.
By giving
buttons the same visual style as if they were hovered by a mouse, people who navigate by use of non-mouse input devices (keyboards) will have a visual cue of where keyboard focus presently is in the document.closes #22