Shawnhill121 (feature)half empty heart #247
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds Half empty heart based on existing heart icon, also adds half empty heart to Storybook for testing and index.html for preview.
abdallahalsamman
requested changes
Jan 9, 2019
docs/icons.stories.js
Outdated
| @@ -38,6 +39,9 @@ stories.add('icon', () => { | |||
| 'is-small': 'is-small', | |||
| 'is-medium': 'is-medium', | |||
| 'is-large': 'is-large', | |||
| 'is-half': 'is-half', | |||
There was a problem hiding this comment.
thanks for your PR 😍
42-43 only apply to the heart icon, so they're more an icon than a variation.
Can we add is-half and is-empty after line 20 as normal icons?
There was a problem hiding this comment.
Thanks for the feedback, I'll take care of that. Sorry it's been a little jacked up, I'm used to using git in TFS for version control.
index.html
Outdated
| @@ -165,6 +165,16 @@ <h2 class="title">Form</h2> | |||
| </div> | |||
| </div> | |||
| </div> | |||
| <div> | |||
There was a problem hiding this comment.
I think this change doesn't belong to this PR, right?
Can we remove it please?
There was a problem hiding this comment.
Sorry, I removed it from this one.
Removes the File Input code from the previous PR.
Moves is-half and is-empty to from size selection to Icons section as they only affect the heart icon.
BcRikko
added
the
waiting - contributor
|
Closing this because of #387. |
guastallaigor
removed
the
waiting - contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds Half-Empty Heart Icons to the existing Icon set, and also to the Index.html page and Storybook Icons.
Compatibility
This adds a new half empty heart icon, based on the existing one. This does not alter any existing icons.
Caveats
None.