Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grammar and misc fixes to README #307

Merged
merged 5 commits into from Feb 26, 2019
Merged

Grammar and misc fixes to README #307

merged 5 commits into from Feb 26, 2019

Conversation

davidcralph
Copy link
Contributor

Description
Fixes some grammar issues related to the README file.

Compatibility
Shouldn't break anything!

Caveats
None that I know of.

@guastallaigor guastallaigor requested a review from a team February 25, 2019 21:52
@guastallaigor guastallaigor added enhancement New feature or request documentation Adding, removing, or updating documentation labels Feb 25, 2019
BcRikko
BcRikko requested changes Feb 26, 2019
View reviewed changes
Copy link
Member

@BcRikko BcRikko left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙇

Oops, commitlint has failed. 😱

Could you try the following git command👍

# edit your commit message
$ git commit --amend -m "fix(readme.md): grammar and misc fixes to readme

# force push branch
$ git push --force-with-lease origin develop

@davidcralph
Copy link
Contributor Author

Ran the commands, accidentally forgot to copy the e on the end of the first one. Is there any way I can fix this?

@BcRikko
Copy link
Member

BcRikko commented Feb 26, 2019 •
edited

Umm...
It's troublesome, so it's ok as it is 👍

If you want to do, it is the following command:

$ git rebase -i HEAD~4

# edit commit message

$ git commit --amend
$ git rebase --continue

@BcRikko BcRikko mentioned this pull request Feb 26, 2019
Merged
4 tasks
BcRikko
BcRikko approved these changes Feb 26, 2019
View reviewed changes
Copy link
Member

@BcRikko BcRikko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍
Thanks 🙇

@BcRikko BcRikko merged commit 1dfbdd3 into nostalgic-css:develop Feb 26, 2019
@davidcralph
Copy link
Contributor Author

no problem!

@BcRikko
Copy link
Member

BcRikko commented Feb 27, 2019

🎉 This PR is included in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@evaporei evaporei mentioned this pull request Nov 7, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BcRikko BcRikko BcRikko approved these changes

Assignees

@davidcralph davidcralph

Labels
documentation Adding, removing, or updating documentation enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@davidcralph @BcRikko @guastallaigor