Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix radio and checkbox style in ios #350

Merged
merged 2 commits into from
Jul 3, 2019
Merged

Fix radio and checkbox style in ios #350

merged 2 commits into from
Jul 3, 2019

Conversation

kyu-suke
Copy link
Contributor

Description
I updated radio and checkbox style in iOS.
-webkit-appearance: none seems not to work in iOS.
So I added visibility: none;

  • checkbox
    checkbox

  • radio
    radio

ref #8

Thanks for your review 馃檹

@guastallaigor guastallaigor requested a review from a team June 27, 2019 17:07
@guastallaigor guastallaigor added the bug Something isn't working label Jun 27, 2019
@BcRikko
Copy link
Member

BcRikko commented Jun 28, 2019

Thanks for your pull request. 馃帀

I'm concerned about accessibility. 馃

visibility: hidden visibility: visible
hidden visible

If specify visibility: hidden;, radios and checkboxes will be removed from the accessibility tree.
I don't know much about accessibility, so I can't think of any other good idea. 馃槶
Do you have other good ideas? 馃

ref: visibility - CSS: Cascading Style Sheets | MDN

@kyu-suke
Copy link
Contributor Author

@BcRikko
Thanks for your review!!
oh..
You are correct!
I confirmed that radio that is set visibility: none is not focused by tab 馃檹
I found some ways about hiding input without accessibility loss.
I will try these.
If it will be success, I push to this pr 馃憤

@kyu-suke
fix: accessibility
3c2e25a 
* delete `visibility: hidden;`
* set 1px height and width to radio and checkbox
* set background color
@kyu-suke
Copy link
Contributor Author

@BcRikko

I updated!

Description

  • Hide radio and checkbox without accesibillity loss in iOS.
    • Set 1px to these width and height. (for accesibillity)
    • Set same color as background(default, is-dark) to these background.

view
radios

accesibillity
accesibillity

There may be points I have missed.
If you have any opinion please.

thanks!

BcRikko
BcRikko approved these changes Jul 3, 2019
View reviewed changes
Copy link
Member

@BcRikko BcRikko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 馃檱
LGTM 馃帀

@BcRikko BcRikko merged commit 883befc into nostalgic-css:develop Jul 3, 2019
@BcRikko BcRikko mentioned this pull request Jul 3, 2019
Merged
@BcRikko
Copy link
Member

BcRikko commented Sep 30, 2019

馃帀 This PR is included in version 2.2.1 馃帀

The release is available on:

Your semantic-release bot 馃摝馃殌

@guastallaigor guastallaigor mentioned this pull request Oct 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BcRikko BcRikko BcRikko approved these changes

Assignees

@kyu-suke kyu-suke

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kyu-suke @BcRikko @guastallaigor