Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable font-smoothing #40

Merged
merged 2 commits into from Nov 30, 2018
Merged

disable font-smoothing #40

merged 2 commits into from Nov 30, 2018

Conversation

stewartrule
Copy link
Contributor

Just a tiny change to remove the anti-aliasing from the font :)

Currently:
screen shot 2018-11-30 at 10 33 38

Without font-smoothing:
screen shot 2018-11-30 at 10 33 54

Copy link
Member

@BcRikko BcRikko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉
I didn't know font-smoothing property 😆

I commented, please confirm 🙏

@@ -17,6 +17,7 @@ html {
-webkit-text-size-adjust: 100%;
-ms-overflow-style: scrollbar;
-webkit-tap-highlight-color: rgba(0, 0, 0, 0);
-webkit-font-smoothing : none;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move this code to scss/base/generic.scss 🙏
I don't want to change reboot.scss, because I copy and use Bootstrap Reboot v4.1.3.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alright, I moved it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 😍

Copy link
Member

@BcRikko BcRikko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍
LGTM 🎉

@BcRikko BcRikko merged commit 40bce78 into nostalgic-css:master Nov 30, 2018
@stewartrule stewartrule deleted the feat/font branch November 30, 2018 14:53
@BcRikko
Copy link
Member

BcRikko commented Dec 18, 2018

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants