Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix nip46 login with nip05 #214

Merged
merged 2 commits into from
Apr 16, 2024
Merged

fix nip46 login with nip05 #214

merged 2 commits into from
Apr 16, 2024

Conversation

sepehr-safari
Copy link
Contributor

  • added ndk instance to NDKUser.fromNip05 to fix No NDK instance found error.
  • replaced Promise.then with await to wait for the NDKUser and fix Remote pubkey not set error.

@sepehr-safari
Copy link
Contributor Author

  • fixed relaySet by forcing rpc to use user defined relays fetched from their nip05

@sepehr-safari
Copy link
Contributor Author

@pablof7z ready for review buddy.

@pablof7z pablof7z merged commit 2b7d836 into nostr-dev-kit:master Apr 16, 2024
@sepehr-safari
Copy link
Contributor Author

thank you dear @pablof7z would you mind releasing a new version, as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablof7z pablof7z pablof7z approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sepehr-safari @pablof7z