-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
index zap senders with P tag #954
Conversation
We use primal for zaps sent and zaps received by collection of pubkeys. Specifically interested in all economic activity by someone's follow list. |
Definite concept ack |
ack. huge oversight in the original spec. |
@@ -128,7 +129,7 @@ The following should be true of the `zap receipt` event: | |||
|
|||
- The `content` SHOULD be empty. | |||
- The `created_at` date SHOULD be set to the invoice `paid_at` date for idempotency. | |||
- `tags` MUST include the `p` tag AND optional `e` tag from the `zap request` AND optional `a` tag from the `zap request`. | |||
- `tags` MUST include the `p` tag (zap recipient) AND optional `e` tag from the `zap request` AND optional `a` tag from the `zap request` AND optional `P` tag from the pubkey of the zap request (zap sender). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the uppercase P
can be pretty confusing, might be better as something like sender
On Sat, Dec 30, 2023 at 08:38:35PM -0800, benthecarman wrote:
the uppercase `P` can be pretty confusing, might be better as something like `sender`
Then it wouldn't be efficiently queryable. most relays only index single-char tags.
|
Probably better if zap services can add this tag to the receipt and its not needed in zap request at all? I already implemented this for snort / zap.stream zaps |
LGTM It is worth mentioning that the Zapper service can |
zaps are not proof of anything |
Implemented in rust-nostr: rust-nostr/nostr#230 |
I see the What if we use the So the filter will be: What do you think? |
For added context, if you look at my rust-nostr PR, this change is really ugly for typed languages where we already have a type defined for p, so we need to name this one UpperP |
A lot of blood has been shed by the lack of an index to find zaps sent by a pubkey.
Mutiny wallet is running a primal index server just to be able to run this simple query.
CHILDREN ARE DYING!