Bug when loadImage into RemoteViewsFactory #199

daimonkor · 2013-03-07T22:37:05Z

    File cacheDir = new File(WidgetProvider.IMG_PATH);
            DisplayImageOptions optionsWithFakeDisplayer = new DisplayImageOptions.Builder()
                    .displayer(new FadeInBitmapDisplayer(2000)).cacheOnDisc()
                    .showImageForEmptyUri(R.drawable.ic_launcher)
                    .showStubImage(R.drawable.ic_launcher).build();

            ImageLoaderConfiguration config = new ImageLoaderConfiguration.Builder(
                    this).threadPoolSize(3)
                    .threadPriority(Thread.NORM_PRIORITY - 1)
                    .denyCacheImageMultipleSizesInMemory().offOutOfMemoryHandling()
                    .memoryCache(new UsingFreqLimitedMemoryCache(2 * 1024 * 1024))
                    .discCache(new UnlimitedDiscCache(cacheDir))
                    .defaultDisplayImageOptions(optionsWithFakeDisplayer) 
                    .enableLogging().build();
            ImageLoader.getInstance().init(config);

////////////////////////
public class ClansListViewFactory implements
        RemoteViewsService.RemoteViewsFactory {

    @Override
    public RemoteViews getViewAt(int position) {
        row = null;
        row = new RemoteViews(context.getPackageName(),
                R.layout.clans_clan_thumbnail);

        if(arrayList != null && !arrayList.isEmpty()){
              ImageLoader.getInstance().loadImage(arrayList.get(position).getClansIconSrc(),
                    new SimpleImageLoadingListener() {

                        @Override
                        public void onLoadingComplete(String imageUri,
                                View view, Bitmap loadedImage) {
            row.setImageViewBitmap(R.id.clan_icon,loadedImage);
                            super.onLoadingComplete(imageUri, view, loadedImage);
                        }
                    });


        }

        return row;
    }

it is listview factory for widget
ImageLoader work well into another activity
please help

nostra13 · 2013-03-08T07:55:51Z

It seems getViewAt(int position) is called from non-UI thread. ImageLoader.loadImage(...) should be called on UI thread.
Try to change your logic or play with Looper.prepare() (call it before ImageLoader.loadImage(...))

daimonkor · 2013-03-08T09:38:24Z

sorry but http://prntscr.com/vgrvr

Looper.prepare() was pasted before ImageLoader.loadImage(...)

daimonkor · 2013-03-08T19:02:54Z

        if(Looper.myLooper() == null)
            Looper.prepare();
                    ImageLoader.getInstance().loadImage(arrayList.get(ClansListViewFactory.this.position).getClansIconSrc(),
                            new SimpleImageLoadingListener() {
                                @Override
                                public void onLoadingFailed(String imageUri, View view,
                                        FailReason failReason) {
                                    Log.v("FAILED", "DSDDDDDDDDD");
                                Drawable drawable =  ClansListViewFactory.this.context.getResources().getDrawable( R.drawable.ic_launcher );
                                Bitmap bitmap = ((BitmapDrawable) com.icebergteam.wotwidget.news.ui.NewsItem.scaleImage(drawable,50)).getBitmap();
                                row.setImageViewBitmap(R.id.clan_icon, bitmap);
                                    super.onLoadingFailed(imageUri, view, failReason);
                                }

                                @Override
                                public void onLoadingComplete(String imageUri,
                                        View view, Bitmap loadedImage) {
                                    Log.v("COMPLETE", "DSDDDDDDDDD");
                            Drawable drawable = new BitmapDrawable(loadedImage);
                            Bitmap bitmap = ((BitmapDrawable) com.icebergteam.wotwidget.news.ui.NewsItem.scaleImage(drawable,50)).getBitmap();
                                row.setImageViewBitmap(R.id.clan_icon,bitmap);
                                    super.onLoadingComplete(imageUri, view, loadedImage);
                                }

                                @Override
                                public void onLoadingStarted(String imageUri,
                                        View view) {
                                    Log.v("DDDDDDDDDDDD", "DSDDDDDDDDD");
                                    super.onLoadingStarted(imageUri, view);
                                }
                            });

http://prntscr.com/vihda
missing call onLoadingComplete(...)

nostra13 · 2013-03-08T19:18:50Z

I think you need synchronous image loading.
Try to use next code in getViewAt(...):

final Object lock = new Object();
boolean loaded = false;
ImageSize targetImageSize = new ImageSize(70, 70);
ImageLoader.getInstance().loadImage(imageUri, targetImageSize, options, new SimpleImageLoadingListener() {
    @Override
    public void onLoadingComplete(String imageUri, View view, Bitmap loadedImage) {
        loaded = true;
        // Do whatever you want with loadedImage

        synchronize(lock) {
            lock.notifyAll();
        }
    }
});
if (!loaded) {
    synchronize(lock) {
        lock.wait();
    }
}

Remove all your code about Looper.

daimonkor · 2013-03-08T19:36:13Z

http://prntscr.com/vilop Looper need

@Override
    public RemoteViews getViewAt(int position) {
        this.position = position;
        this.row = null;
        this.row = new RemoteViews(context.getPackageName(),
                R.layout.clans_clan_thumbnail);

        if(arrayList != null && !arrayList.isEmpty()){
            this.lock = null;
            this.lock = new Object();
            this.loaded = false;
                    ImageLoader.getInstance().loadImage(arrayList.get(ClansListViewFactory.this.position).getClansIconSrc(),
                            new SimpleImageLoadingListener() {
                                @Override
                                public void onLoadingFailed(String imageUri, View view,
                                        FailReason failReason) {
                                    Log.v("FAILED", "DSDDDDDDDDD");
                                Drawable drawable =  ClansListViewFactory.this.context.getResources().getDrawable( R.drawable.ic_launcher );
                                Bitmap bitmap = ((BitmapDrawable) com.icebergteam.wotwidget.news.ui.NewsItem.scaleImage(drawable,50)).getBitmap();
                                ClansListViewFactory.this.row.setImageViewBitmap(R.id.clan_icon, bitmap);
                                ClansListViewFactory.this.loaded = true;
                                 synchronized(ClansListViewFactory.this.lock) {
                                     ClansListViewFactory.this. lock.notifyAll();
                                    super.onLoadingFailed(imageUri, view, failReason);
                                }
                                }

                                @Override
                                public void onLoadingComplete(String imageUri,
                                        View view, Bitmap loadedImage) {
                                    Log.v("COMPLETE", "DSDDDDDDDDD");
                            Drawable drawable = new BitmapDrawable(loadedImage);
                            Bitmap bitmap = ((BitmapDrawable) com.icebergteam.wotwidget.news.ui.NewsItem.scaleImage(drawable,50)).getBitmap();
                            ClansListViewFactory.this.row.setImageViewBitmap(R.id.clan_icon,bitmap);
                                    super.onLoadingComplete(imageUri, view, loadedImage);
                                    ClansListViewFactory.this.loaded =true;
                                }


                            });

                    if (!ClansListViewFactory.this.loaded) {
                        synchronized(ClansListViewFactory.this.lock) {
                            try {
                                ClansListViewFactory.this.lock.wait();
                            } catch (InterruptedException e) {
                                // TODO Auto-generated catch block
                                e.printStackTrace();
                            }
                        }
                    }   



        }

        return row;
    }

nostra13 · 2013-03-08T19:44:56Z

Ok, try with Looper.

daimonkor · 2013-03-08T19:54:09Z

@Override
    public RemoteViews getViewAt(int position) {
        this.position = position;
        this.row = null;
        this.row = new RemoteViews(context.getPackageName(),
                R.layout.clans_clan_thumbnail);

        if(arrayList != null && !arrayList.isEmpty()){
            this.lock = null;
            this.lock = new Object();
            this.loaded = false;
            if(Looper.myLooper() == null){
                Looper.prepare();
            }
                    ImageLoader.getInstance().loadImage(arrayList.get(ClansListViewFactory.this.position).getClansIconSrc(),
                            new SimpleImageLoadingListener() {
                                @Override
                                public void onLoadingFailed(String imageUri, View view,
                                        FailReason failReason) {

                                    Log.v("FAILED", "DSDDDDDDDDD");
                                Drawable drawable =  ClansListViewFactory.this.context.getResources().getDrawable( R.drawable.ic_launcher );
                                Bitmap bitmap = ((BitmapDrawable) com.icebergteam.wotwidget.news.ui.NewsItem.scaleImage(drawable,50)).getBitmap();
                                ClansListViewFactory.this.row.setImageViewBitmap(R.id.clan_icon, bitmap);
                                ClansListViewFactory.this.loaded = true;
                                     synchronized(ClansListViewFactory.this.lock) {
                                         ClansListViewFactory.this. lock.notifyAll();
                                        super.onLoadingFailed(imageUri, view, failReason);
                                    }
                                }

                                @Override
                                public void onLoadingComplete(String imageUri,
                                        View view, Bitmap loadedImage) {

                                        Log.v("COMPLETE", "DSDDDDDDDDD");
                                        Drawable drawable = new BitmapDrawable(loadedImage);
                                        Bitmap bitmap = ((BitmapDrawable) com.icebergteam.wotwidget.news.ui.NewsItem.scaleImage(drawable,50)).getBitmap();
                                        ClansListViewFactory.this.row.setImageViewBitmap(R.id.clan_icon,bitmap);

                                     ClansListViewFactory.this.loaded =true;

                                     synchronized(ClansListViewFactory.this.lock) {

                                         ClansListViewFactory.this. lock.notifyAll();
                                        super.onLoadingComplete(imageUri, view, loadedImage);
                                    }
                                }


                            });

                    if (!ClansListViewFactory.this.loaded) {
                        synchronized(ClansListViewFactory.this.lock) {
                            try {
                                ClansListViewFactory.this.lock.wait();
                            } catch (InterruptedException e) {

                                e.printStackTrace();
                            }
                        }
                    }   


        }

        return row;
    }

http://prntscr.com/vip66 one call getViewAt(...) and missing call complete or failed
I modified code (paste log)
http://prntscr.com/viyc3
please help

daimonkor · 2013-03-10T22:53:01Z

@Override
    public RemoteViews getViewAt(int position) {
    final RemoteViews row = new RemoteViews(context.getPackageName(),
                R.layout.clans_clan_thumbnail);

        if(arrayList != null && !arrayList.isEmpty()){
            final Object lock = new Object();
            loaded = false;
            if(Looper.myLooper() == null){
                Looper.prepare();
            }

            LogManager.LogV(className, "getViewAt", "run", position);
                    ImageLoader.getInstance().loadImage(arrayList.get(position).getClansIconSrc(),
                            new SimpleImageLoadingListener() {
                                @Override
                                public void onLoadingStarted(String imageUri,
                                        View view) {

                                    loaded = true;
                                    Log.v("Started", "DSDDDDDDDDD");
                                    synchronized(lock) {
                                         lock.notifyAll();

                                    }
                                }

                                @Override
                                public void onLoadingFailed(String imageUri, View view,
                                        FailReason failReason) {
                                    loaded = true;
                                    Log.v("FAILED", "DSDDDDDDDDD");
                                Drawable drawable =  ClansListViewFactory.this.context.getResources().getDrawable( R.drawable.ic_launcher );
                                Bitmap bitmap = ((BitmapDrawable) com.icebergteam.wotwidget.news.ui.NewsItem.scaleImage(drawable,50)).getBitmap();
                                row.setImageViewBitmap(R.id.clan_icon, bitmap);

                                     synchronized(lock) {
                                         lock.notifyAll();

                                    }
                                }

                                @Override
                                public void onLoadingComplete(String imageUri,
                                        View view, Bitmap loadedImage) {
                                     loaded =true;
                                        Log.v("COMPLETE", "DSDDDDDDDDD");
                                        Drawable drawable = new BitmapDrawable(loadedImage);
                                        Bitmap bitmap = ((BitmapDrawable) com.icebergteam.wotwidget.news.ui.NewsItem.scaleImage(drawable,50)).getBitmap();
                                        row.setImageViewBitmap(R.id.clan_icon,bitmap);


                                     synchronized(lock) {

                                         lock.notifyAll();

                                    }
                                }

                            });

                    if (!loaded) {
                        LogManager.LogV(className, "getViewAt", "if wait");
                        synchronized(lock) {
                            try {
                                LogManager.LogV(className, "getViewAt", "if wait sync");
                                lock.wait();
                            } catch (Exception e) {
                                // TODO Auto-generated catch block
                                e.printStackTrace();
                            }
                        }
                    }   

        }
        LogManager.LogV(className, "getViewAt", "return");
        return row;
    }

http://prntscr.com/vtr1a
feedback function "started" call normally, but "failed" or "completed" call missing
please help

nostra13 · 2013-03-13T12:38:31Z

It would be better you send me your project (if you can). So I can play with it to search the solution.

daimonkor · 2013-03-13T12:41:54Z

please write your skype

nostra13 · 2013-03-13T13:08:58Z

Write me on email - nostra13[at]gmail[dot]com

NateWickstrom · 2013-04-11T04:04:39Z

Any luck on this? I'm wanting to do the same thing...

IstiN · 2013-05-20T22:41:02Z

I've fixed it. See code:

    Map<Integer, Boolean> flags = Collections.synchronizedMap(new HashMap<Integer, Boolean>());
    Bitmap mBitmap;
    Handler handler = new Handler(Looper.getMainLooper());

    @Override
    public RemoteViews getViewAt(final int position) {
        flags.put(position, false);
        handler.post(new Runnable() {
            @Override
            public void run() {
                ImageLoader.getInstance().loadImage(item.getImageUrl(), new SimpleImageLoadingListener() {
                    @Override
                    public void onLoadingStarted(String imageUri, View view) {
                    }

                    @Override
                    public void onLoadingFailed(String imageUri, View view, FailReason failReason) {
                        flags.put(position, true);
                    }

                    @Override
                    public void onLoadingCancelled(String imageUri, View view) {
                        flags.put(position, true);
                    }

                    @Override
                    public void onLoadingComplete(String arg0, View arg1, Bitmap bitmap) {
                        mBitmap = bitmap;
                        flags.put(position, true);
                    }
                });
            }
        });

        while (!flags.get(position)) {
            Thread.sleep(200l);
        }
        flags.put(position, false);
        if (mBitmap != null) {
            row.setImageViewBitmap(R.id.icon, mBitmap);
        } else {
            row.setImageViewResource(R.id.icon, R.drawable.bg_cover);
        }
        mBitmap = null;
        flags.put(position, false);
        handler.post(new Runnable() {
            @Override
            public void run() {
                ImageLoader.getInstance().loadImage(item.getImageUrl(), new SimpleImageLoadingListener() {
                    @Override
                    public void onLoadingStarted(String imageUri, View view) {
                    }

                    @Override
                    public void onLoadingFailed(String imageUri, View view, FailReason failReason) {
                        flags.put(position, true);
                    }

                    @Override
                    public void onLoadingCancelled(String imageUri, View view) {
                        flags.put(position, true);
                    }

                    @Override
                    public void onLoadingComplete(String arg0, View arg1, Bitmap bitmap) {
                        mBitmap = bitmap;
                        flags.put(position, true);
                    }
                });
            }
        });

        while (!flags.get(position)) {
            Thread.sleep(200l);
        }
        flags.put(position, false);
        if (mBitmap != null) {
            row.setImageViewBitmap(R.id.icon, mBitmap);
        } else {
            row.setImageViewResource(R.id.icon, R.drawable.bg_cover);
        }
        mBitmap = null;
    }

daimonkor · 2013-05-20T22:45:05Z

ÉÌÉ Ñ ÐÕÔÁÀÓØ ÉÌÉ ÔÕÔ ÉÄ£Ô 2 ÒÁÚÁ ÐÏÄÒÑÄ ÏÄÉÎÁËÏ×ÙÊ ËÏÄ?

2013/5/21 Vova Klyshevich notifications@github.com

I've fixed it. See code:

Map flags = Collections.synchronizedMap(new HashMap());

Bitmap mBitmap;

Handler handler = new Handler(Looper.getMainLooper());

@OverRide https://github.com/Override
public RemoteViews getViewAt(final int position) {
...

flags.put(position, false);
handler.post(new Runnable() {

                    @Override
                    public void run() {
                        ImageLoader.getInstance().loadImage(item.getImageUrl(), new SimpleImageLoadingListener() {

                            @Override
                            public void onLoadingStarted(String imageUri, View view) {

                            }

                            @Override
                            public void onLoadingFailed(String imageUri, View view,
                                    FailReason failReason) {
                                flags.put(position, true);
                            }

                            @Override
                            public void onLoadingCancelled(String imageUri,
                                    View view) {
                                flags.put(position, true);
                            }

                            @Override
                            public void onLoadingComplete(String arg0, View arg1, Bitmap bitmap) {
                                mBitmap = bitmap;
                                flags.put(position, true);
                            }

                        });
                    }

                });

                while (!flags.get(position)) {
                    Thread.sleep(200l);
                }
                flags.put(position, false);
                if (mBitmap != null) {
                    row.setImageViewBitmap(R.id.icon, mBitmap);
                } else {
                    row.setImageViewResource(R.id.icon, R.drawable.bg_cover);
                }
                mBitmap = null;flags.put(position, false);
                handler.post(new Runnable() {

                    @Override
                    public void run() {
                        ImageLoader.getInstance().loadImage(item.getImageUrl(), new SimpleImageLoadingListener() {

                            @Override
                            public void onLoadingStarted(String imageUri, View view) {

                            }

                            @Override
                            public void onLoadingFailed(String imageUri, View view,
                                    FailReason failReason) {
                                flags.put(position, true);
                            }

                            @Override
                            public void onLoadingCancelled(String imageUri,
                                    View view) {
                                flags.put(position, true);
                            }

                            @Override
                            public void onLoadingComplete(String arg0, View arg1, Bitmap bitmap) {
                                mBitmap = bitmap;
                                flags.put(position, true);
                            }

                        });
                    }

                });

                while (!flags.get(position)) {
                    Thread.sleep(200l);
                }
                flags.put(position, false);
                if (mBitmap != null) {
                    row.setImageViewBitmap(R.id.icon, mBitmap);
                } else {
                    row.setImageViewResource(R.id.icon, R.drawable.bg_cover);
                }
                mBitmap = null;

...
}

Reply to this email directly or view it on GitHubhttps://github.com//issues/199#issuecomment-18178500
.

ëÏÒÎÉÅÃ äÍÉÔÒÉÊ

laaptu · 2013-07-12T10:41:06Z

@IstiN : Could you format your code a little and if not hassle could you please explain the logic behind.
Thanks in advance

nostra13 · 2013-11-19T21:10:57Z

I think you can use sync methods of ImageLoader to display images now (loadImageSync(...))

grebulon · 2014-11-20T08:19:48Z

Does Vova's solution pre-dates loadImageSync?

nostra13 · 2014-11-20T12:09:14Z

Yes, it does.

betalita · 2014-12-03T08:34:50Z

thanks a lot

nostra13 closed this as completed Nov 19, 2013

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug when loadImage into RemoteViewsFactory #199

Bug when loadImage into RemoteViewsFactory #199

daimonkor commented Mar 7, 2013

nostra13 commented Mar 8, 2013

daimonkor commented Mar 8, 2013

daimonkor commented Mar 8, 2013

nostra13 commented Mar 8, 2013

daimonkor commented Mar 8, 2013

nostra13 commented Mar 8, 2013

daimonkor commented Mar 8, 2013

daimonkor commented Mar 10, 2013

nostra13 commented Mar 13, 2013

daimonkor commented Mar 13, 2013

nostra13 commented Mar 13, 2013

NateWickstrom commented Apr 11, 2013

IstiN commented May 20, 2013

daimonkor commented May 20, 2013

laaptu commented Jul 12, 2013

nostra13 commented Nov 19, 2013

grebulon commented Nov 20, 2014

nostra13 commented Nov 20, 2014

betalita commented Dec 3, 2014

Bug when loadImage into RemoteViewsFactory #199

Bug when loadImage into RemoteViewsFactory #199

Comments

daimonkor commented Mar 7, 2013

nostra13 commented Mar 8, 2013

daimonkor commented Mar 8, 2013

daimonkor commented Mar 8, 2013

nostra13 commented Mar 8, 2013

daimonkor commented Mar 8, 2013

nostra13 commented Mar 8, 2013

daimonkor commented Mar 8, 2013

daimonkor commented Mar 10, 2013

nostra13 commented Mar 13, 2013

daimonkor commented Mar 13, 2013

nostra13 commented Mar 13, 2013

NateWickstrom commented Apr 11, 2013

IstiN commented May 20, 2013

daimonkor commented May 20, 2013

laaptu commented Jul 12, 2013

nostra13 commented Nov 19, 2013

grebulon commented Nov 20, 2014

nostra13 commented Nov 20, 2014

betalita commented Dec 3, 2014