New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potential null pointer access in LoadAndDisplayImageTask #271

Closed

koral-- opened this issue May 2, 2013 · 1 comment

Labels

Bug

koral-- commented May 2, 2013

Lines 281-282:

            if (cacheDir == null || !cacheDir.exists()) {
                cacheDir.mkdirs();

If cacheDir is null then NPE will always be thrown. Perhaps it should be:

if (cacheDir != null && !cacheDir.exists())

Owner

nostra13 commented May 19, 2013

Right. Thanks for the bug.

nostra13 added a commit that referenced this issue


          Issue #271 - Fixed potential NPE

d3b2276

koral-- closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment