Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

center window on create and set_window_size() #348

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

RehkitzDev
Copy link

centers the window on the main screen.
changes only affect windows platform.

probably nice to have on linux & macos too.

@not-fl3
Copy link
Owner

not-fl3 commented Mar 10, 2023

To be honest I would prefer window manager to do its job and place window accordingly, at least by default.

Maybe add a flag in conf.platform to make this behavior optional?

@RehkitzDev
Copy link
Author

Where is the window manager you mentioned? Add set_window_position in NativeDisplay? Currently only have the ability to add this on windows.
I'm not sure about adding a flag for this. Who would want the default windows behavior? It spawns the window almost at the top left of the screen.

@not-fl3
Copy link
Owner

not-fl3 commented Mar 11, 2023

I just believe that apps should not manage their window placement, its the job for window manager (or the entire os in case of windows/mac), so I would prefer anything forcing window size/position to be optional :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants