Add a quit shortcut to the osx menu bar #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not-fl3
reviewed
Jun 29, 2024
not-fl3
reviewed
Jun 29, 2024
src/native/macos.rs
Outdated
| let app_menu: ObjcId = msg_send![class!(NSMenu), new]; | ||
|
|
||
| // Hook up the menu components to the application | ||
| let () = msg_send![app_menu_item, setSubmenu: app_menu]; |
There was a problem hiding this comment.
up to you, but there is a special macro with a dash, msg_send_![app_menu_item, setSubmenu: app_menu];
There was a problem hiding this comment.
Oh that's nicer looking. Switched to using that.
|
Thanks for PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Command+Q functionality by adding a "Quit AppName" entry to the top menu bar. This is the normal way to implement the command-q shortcut on osx, and lets you rebind it in system keyboard settings.
Fixes not-fl3/macroquad#649
Note that on osx on master, clicking on a menu bar item currently freezes the window. This is due to #455.