Merge 71884a5 into 87ceca1

notEthan · Dec 13, 2019 · 45f2b23 · 45f2b23
2 parents 87ceca1 + 71884a5
commit 45f2b23
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/lib/jsi/base.rb b/lib/jsi/base.rb
@@ -55,10 +55,7 @@ def to_s
       # @return [String] a name for a constant for this class, generated from the
       #   schema_id. only used if the class is not assigned to another constant.
       def schema_classes_const_name
-        name = schema.schema_id.gsub(/[^\w]/, '_')
-        name = 'X' + name unless name[/\A[a-zA-Z]/]
-        name = name[0].upcase + name[1..-1]
-        name
+        'X' + schema.schema_id.gsub(/[^\w]/, '_')
       end
 
       # @return [String] a constant name of this class

diff --git a/test/base_test.rb b/test/base_test.rb
@@ -34,7 +34,7 @@
   describe 'class name' do
     let(:schema_content) { {'id' => 'https://jsi/BaseTest'} }
     it 'generates a class name from schema_id' do
-      assert_equal('JSI::SchemaClasses::Https___jsi_BaseTest_', subject.class.name)
+      assert_equal('JSI::SchemaClasses::Xhttps___jsi_BaseTest_', subject.class.name)
     end
     it 'uses an existing name' do
       assert_equal('NamedSchemaInstance', NamedSchemaInstance.name)