don't stringify hash keys in Base#initialize #12
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while it may arguably be better for a JSI to treat hash keys that are symbols as if they were strings, calling deep_stringify_symbol_keys in Base#initialize is, for one thing, very much a half-assed solution since
some_jsi[:foo]
is not the same assome_jsi['foo']
, and also problematic in that the JSI's instance then may or may not refer to the same actual object as the instance that was passed to #initialize.in the future I might decide that Base#initialize does a deep stringifying copy of its instance if I fully implement something more like ActiveSupport::HashWithIndifferentAccess within JSI::Base. but I kind of doubt it.