splat keywords #239
Merged
splat keywords #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
though Array#pack doesn't take keyword `buffer` on every ruby, so guard it
having a mixture of positional / keyword arguments doesn't work when the positional argument responds to #to_hash, and passing keywords to positional arguments stops working in ruby 3
since the property accessors pass **kw, #[] needs to accept keywords even though they are only ever empty, until ruby 2.5 to be removed at some point.
…s instead of *arguments]
…arguments these only go to Base#[]
…ts to #[] rather than positional *arguments
…2 and 3 this is pretty terrible, but keyword params are just not compatible between the two for the same method to work on both in any form
incompatible with #[] taking no keywords, until ruby 2.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get keyword arguments compatible with ruby 3